Message ID | 1465469700-9026-1-git-send-email-ben.dooks@codethink.co.uk |
---|---|
State | New |
Headers | show |
On Thu, Jun 9, 2016 at 12:55 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > The array u300_pmx_registers is not declared or used outside > of the driver, so make it static to avoid the following warning: > > drivers/pinctrl/pinctrl-u300.c:673:11: warning: symbol 'u300_pmx_registers' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c index d1af908..9cc80a5 100644 --- a/drivers/pinctrl/pinctrl-u300.c +++ b/drivers/pinctrl/pinctrl-u300.c @@ -670,7 +670,7 @@ struct u300_pmx { * u300_pmx_registers - the array of registers read/written for each pinmux * shunt setting */ -const u32 u300_pmx_registers[] = { +static const u32 u300_pmx_registers[] = { U300_SYSCON_PMC1LR, U300_SYSCON_PMC1HR, U300_SYSCON_PMC2R,
The array u300_pmx_registers is not declared or used outside of the driver, so make it static to avoid the following warning: drivers/pinctrl/pinctrl-u300.c:673:11: warning: symbol 'u300_pmx_registers' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/pinctrl-u300.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)