diff mbox

[ovs-dev,5/6] vagrant: Ignore common ovs-dev.py paths for rsync.

Message ID 1463770199-24391-6-git-send-email-joe@ovn.org
State Changes Requested
Headers show

Commit Message

Joe Stringer May 20, 2016, 6:49 p.m. UTC 
Signed-off-by: Joe Stringer <joe@ovn.org>
---
 Vagrantfile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andy Zhou May 23, 2016, 11:25 p.m. UTC | #1 
On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <joe@ovn.org> wrote:

> Signed-off-by: Joe Stringer <joe@ovn.org>
> ---
>  Vagrantfile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Vagrantfile b/Vagrantfile
> index dab03de56fac..a3d444d366ba 100644
> --- a/Vagrantfile
> +++ b/Vagrantfile
> @@ -65,5 +65,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
>         fedora.vm.provision "test_ovs_kmod", type: "shell", inline:
> $test_kmod
>         fedora.vm.provision "test_ovs_system_userspace", type: "shell",
> inline: $test_ovs_system_userspace
>         fedora.vm.provision "install_rpm", type: "shell", inline:
> $install_rpm
> +       fedora.vm.synced_folder ".", "/vagrant", type: "rsync",
> +           rsync__exclude: [ ".git/", "_build-gcc", "_build-clang",
> "_run"]
>

It seems only libvirt provider currnelty uses rsync. Other platforms mounts
the /vagrant directory. Would
it make sense for the libvirt provider set up to do the same?

>    end
>  end
> --
> 2.8.2
>
>
Joe Stringer May 24, 2016, 1:33 a.m. UTC | #2 
On 23 May 2016 at 16:25, Andy Zhou <azhou@ovn.org> wrote:
>
>
> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <joe@ovn.org> wrote:
>>
>> Signed-off-by: Joe Stringer <joe@ovn.org>
>> ---
>>  Vagrantfile | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Vagrantfile b/Vagrantfile
>> index dab03de56fac..a3d444d366ba 100644
>> --- a/Vagrantfile
>> +++ b/Vagrantfile
>> @@ -65,5 +65,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
>>         fedora.vm.provision "test_ovs_kmod", type: "shell", inline:
>> $test_kmod
>>         fedora.vm.provision "test_ovs_system_userspace", type: "shell",
>> inline: $test_ovs_system_userspace
>>         fedora.vm.provision "install_rpm", type: "shell", inline:
>> $install_rpm
>> +       fedora.vm.synced_folder ".", "/vagrant", type: "rsync",
>> +           rsync__exclude: [ ".git/", "_build-gcc", "_build-clang",
>> "_run"]
>
>
> It seems only libvirt provider currnelty uses rsync. Other platforms mounts
> the /vagrant directory. Would
> it make sense for the libvirt provider set up to do the same?

Hm, I assumed that this was just how it worked and I added this to
prevent it from syncing unnecessary directories.

I'll investigate using shared directories with libvirt.
Joe Stringer June 4, 2016, 1:54 a.m. UTC | #3 
On 23 May 2016 at 18:33, Joe Stringer <joe@ovn.org> wrote:
> On 23 May 2016 at 16:25, Andy Zhou <azhou@ovn.org> wrote:
>>
>>
>> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <joe@ovn.org> wrote:
>>>
>>> Signed-off-by: Joe Stringer <joe@ovn.org>
>>> ---
>>>  Vagrantfile | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Vagrantfile b/Vagrantfile
>>> index dab03de56fac..a3d444d366ba 100644
>>> --- a/Vagrantfile
>>> +++ b/Vagrantfile
>>> @@ -65,5 +65,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
>>>         fedora.vm.provision "test_ovs_kmod", type: "shell", inline:
>>> $test_kmod
>>>         fedora.vm.provision "test_ovs_system_userspace", type: "shell",
>>> inline: $test_ovs_system_userspace
>>>         fedora.vm.provision "install_rpm", type: "shell", inline:
>>> $install_rpm
>>> +       fedora.vm.synced_folder ".", "/vagrant", type: "rsync",
>>> +           rsync__exclude: [ ".git/", "_build-gcc", "_build-clang",
>>> "_run"]
>>
>>
>> It seems only libvirt provider currnelty uses rsync. Other platforms mounts
>> the /vagrant directory. Would
>> it make sense for the libvirt provider set up to do the same?
>
> Hm, I assumed that this was just how it worked and I added this to
> prevent it from syncing unnecessary directories.
>
> I'll investigate using shared directories with libvirt.

I wasn't able to figure out how to get the libvirt backend to support
shared directories in my environment - As soon as I configure the
shared directories, Vagrant complains that virtualization is not
supported on my CPU. I'm guessing it's a limitation/bug on the libvirt
provider side of things.

The shorter path of resistance was to set up VirtualBox and use that,
so I plan to drop these libvirt patches.
Andy Zhou June 6, 2016, 9:01 p.m. UTC | #4 
On Fri, Jun 3, 2016 at 6:54 PM, Joe Stringer <joe@ovn.org> wrote:

> On 23 May 2016 at 18:33, Joe Stringer <joe@ovn.org> wrote:
> > On 23 May 2016 at 16:25, Andy Zhou <azhou@ovn.org> wrote:
> >>
> >>
> >> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <joe@ovn.org> wrote:
> >>>
> >>> Signed-off-by: Joe Stringer <joe@ovn.org>
> >>> ---
> >>>  Vagrantfile | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Vagrantfile b/Vagrantfile
> >>> index dab03de56fac..a3d444d366ba 100644
> >>> --- a/Vagrantfile
> >>> +++ b/Vagrantfile
> >>> @@ -65,5 +65,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do
> |config|
> >>>         fedora.vm.provision "test_ovs_kmod", type: "shell", inline:
> >>> $test_kmod
> >>>         fedora.vm.provision "test_ovs_system_userspace", type: "shell",
> >>> inline: $test_ovs_system_userspace
> >>>         fedora.vm.provision "install_rpm", type: "shell", inline:
> >>> $install_rpm
> >>> +       fedora.vm.synced_folder ".", "/vagrant", type: "rsync",
> >>> +           rsync__exclude: [ ".git/", "_build-gcc", "_build-clang",
> >>> "_run"]
> >>
> >>
> >> It seems only libvirt provider currnelty uses rsync. Other platforms
> mounts
> >> the /vagrant directory. Would
> >> it make sense for the libvirt provider set up to do the same?
> >
> > Hm, I assumed that this was just how it worked and I added this to
> > prevent it from syncing unnecessary directories.
> >
> > I'll investigate using shared directories with libvirt.
>
> I wasn't able to figure out how to get the libvirt backend to support
> shared directories in my environment - As soon as I configure the
> shared directories, Vagrant complains that virtualization is not
> supported on my CPU. I'm guessing it's a limitation/bug on the libvirt
> provider side of things.
>

Too bad! Thanks for trying.

>
> The shorter path of resistance was to set up VirtualBox and use that,
> so I plan to drop these libvirt patches.
>
O.K.
diff mbox

Patch

diff --git a/Vagrantfile b/Vagrantfile
index dab03de56fac..a3d444d366ba 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -65,5 +65,7 @@  Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
        fedora.vm.provision "test_ovs_kmod", type: "shell", inline: $test_kmod
        fedora.vm.provision "test_ovs_system_userspace", type: "shell", inline: $test_ovs_system_userspace
        fedora.vm.provision "install_rpm", type: "shell", inline: $install_rpm
+       fedora.vm.synced_folder ".", "/vagrant", type: "rsync",
+           rsync__exclude: [ ".git/", "_build-gcc", "_build-clang", "_run"]
   end
 end