| Message ID | a206ce4cabf9ba8d376241fc23e9973f6db2443b.1464147910.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 507e617440d70bc4269daac1b0ee96671bf2761a |
| Headers | show |
On 25 May 2016 at 05:45, Baruch Siach <baruch@tkos.co.il> wrote: > Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch" > nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to > match. > > Cc: Rafał Miłecki <zajec5@gmail.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Acked-by: Rafał Miłecki <zajec5@gmail.com>
On Wed, May 25, 2016 at 06:45:10AM +0300, Baruch Siach wrote: > Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch" > nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to > match. > > Cc: Rafał Miłecki <zajec5@gmail.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > Documentation/devicetree/bindings/mtd/nand.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org>
Brian, On Wed, 25 May 2016 06:45:10 +0300 Baruch Siach <baruch@tkos.co.il> wrote: > Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch" > nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to > match. > > Cc: Rafał Miłecki <zajec5@gmail.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> I don't know if we should consider this as a bugfix. If that's the case, can you take it directly in your tree with my Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> Thanks, Boris > --- > Documentation/devicetree/bindings/mtd/nand.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt > index 68342eac2383..3733300de8dd 100644 > --- a/Documentation/devicetree/bindings/mtd/nand.txt > +++ b/Documentation/devicetree/bindings/mtd/nand.txt > @@ -53,7 +53,8 @@ Example: > > nand@0 { > reg = <0>; > - nand-ecc-mode = "soft_bch"; > + nand-ecc-mode = "soft"; > + nand-ecc-algo = "bch"; > > /* controller specific properties */ > };
On Fri, May 27, 2016 at 03:31:53PM +0200, Boris Brezillon wrote: > On Wed, 25 May 2016 06:45:10 +0300 > Baruch Siach <baruch@tkos.co.il> wrote: > > > Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch" > > nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to > > match. > > > > Cc: Rafał Miłecki <zajec5@gmail.com> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > I don't know if we should consider this as a bugfix. If that's the > case, can you take it directly in your tree with my Well, I don't know if it's a "bugfix" per se, but it's obviously correct and has approx 0 risk. > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> Wow, thanks! Three acks! Y'all must really love documentation :) Pushed to linux-mtd.git. Brian
diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt index 68342eac2383..3733300de8dd 100644 --- a/Documentation/devicetree/bindings/mtd/nand.txt +++ b/Documentation/devicetree/bindings/mtd/nand.txt @@ -53,7 +53,8 @@ Example: nand@0 { reg = <0>; - nand-ecc-mode = "soft_bch"; + nand-ecc-mode = "soft"; + nand-ecc-algo = "bch"; /* controller specific properties */ };
Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch" nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to match. Cc: Rafał Miłecki <zajec5@gmail.com> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- Documentation/devicetree/bindings/mtd/nand.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)