| Message ID | 1464142833-30124-1-git-send-email-judge.packham@gmail.com |
|---|---|
| State | Accepted |
| Commit | be86492bdaeb8fdfd8d66bba79a9bd899531b8b0 |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Chris, On 24 May 2016 at 20:20, Chris Packham <judge.packham@gmail.com> wrote: > From: Chris Packham <chris.packham@alliedtelesis.co.nz> > > When setting up a DDR controller it is useful to be able to display > frequencies in a readable form. Make the strmhz() function available in > SPL builds provided there is full vsprintf available. > > Reviewed-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz> > Signed-off-by: Chris Packham <judge.packham@gmail.com> > --- > > lib/Makefile | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> I notice there is print_freq(). Should these be rationalised? Regards, Simon
On 05/25/2016 03:30 PM, Simon Glass wrote: > Hi Chris, > > On 24 May 2016 at 20:20, Chris Packham <judge.packham@gmail.com> wrote: >> From: Chris Packham <chris.packham@alliedtelesis.co.nz> >> >> When setting up a DDR controller it is useful to be able to display >> frequencies in a readable form. Make the strmhz() function available in >> SPL builds provided there is full vsprintf available. >> >> Reviewed-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz> >> Signed-off-by: Chris Packham <judge.packham@gmail.com> >> --- >> >> lib/Makefile | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > I notice there is print_freq(). Should these be rationalised? They appear to do different things. strmhz() populates a string with a value in MHz rounded to 3 places (i.e. the nearest KHz). print_freq() can handle Hz, KHz, MHz and GHz it also prints the output directly rather than to a user supplied buffer. strmhz() is much more widely used but both strmhz() and print_freq() are used in command output ("bdinfo" and "cpu detail" respectively) so I don't think it would be a simple case of swapping one for the other.
diff --git a/lib/Makefile b/lib/Makefile index 02dfa29..f77befe 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -42,7 +42,6 @@ obj-y += rc4.o obj-$(CONFIG_SHA1) += sha1.o obj-$(CONFIG_SUPPORT_EMMC_RPMB) += sha256.o obj-$(CONFIG_SHA256) += sha256.o -obj-y += strmhz.o obj-$(CONFIG_TPM) += tpm.o obj-$(CONFIG_RBTREE) += rbtree.o obj-$(CONFIG_BITREVERSE) += bitrev.o @@ -85,11 +84,11 @@ ifdef CONFIG_SPL_BUILD ifdef CONFIG_USE_TINY_PRINTF obj-$(CONFIG_SPL_SERIAL_SUPPORT) += tiny-printf.o panic.o strto.o else -obj-$(CONFIG_SPL_SERIAL_SUPPORT) += vsprintf.o panic.o strto.o +obj-$(CONFIG_SPL_SERIAL_SUPPORT) += vsprintf.o panic.o strto.o strmhz.o endif else # Main U-Boot always uses the full printf support -obj-y += vsprintf.o panic.o strto.o +obj-y += vsprintf.o panic.o strto.o strmhz.o endif subdir-ccflags-$(CONFIG_CC_OPTIMIZE_LIBS_FOR_SPEED) += -O2