Message ID | gerrit.1463841799423.If1ad5d2d68c85733306c75ea62f67fe8fbc143b3@gerrit.osmocom.org |
---|---|
State | New |
Headers | show |
Patch Set 1: Why not change the define itself?
Patch Set 1: Code-Review+2
> Why not change the define itself?
because then the name would be wrong. The actual AMR codec payload cannot be larger than 33 bytes. So if you change the #define value, you also need to come up with a new, more suitable name.
diff --git a/openbsc/src/libtrau/rtp_proxy.c b/openbsc/src/libtrau/rtp_proxy.c index 8c982c9..6c04610 100644 --- a/openbsc/src/libtrau/rtp_proxy.c +++ b/openbsc/src/libtrau/rtp_proxy.c @@ -172,7 +172,7 @@ /* always allocate for the maximum possible size to avoid * fragmentation */ new_msg = msgb_alloc(sizeof(struct gsm_data_frame) + - MAX_RTP_PAYLOAD_LEN, "GSM-DATA (TCH)"); + MAX_RTP_PAYLOAD_LEN+1, "GSM-DATA (TCH)"); if (!new_msg) return -ENOMEM;