| Message ID | 374F2CC9-BE5B-4948-8916-E67FC37E8E19@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
On Wed, May 11, 2016 at 02:45:32PM -0500, Bill Schmidt wrote: > When fixing PR70963, I introduced a test case that didn’t sufficiently constrain > the target architecture. Although the built-ins I was testing are available on any > platform supporting VSX, the use of vec_all_eq for vector double and vector long > long requires at least a POWER8 target. This patch remedies this by ensuring > the test will not run unless p8vector support is available. > > Verified on powerpc64-unknown-linux-gnu and powerpc64le-unknown-linux-gnu. > Is this ok for trunk? I will wait a bit longer before deploying to earlier releases… It is okay, thanks, Segher > 2016-05-11 Bill Schmidt <wschmidt@linux.vnet.ibm.com> > > * gcc.target/powerpc/pr70963.c: Require at least power8 at both > compile and run time.
Index: gcc/testsuite/gcc.target/powerpc/pr70963.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr70963.c (revision 236082) +++ gcc/testsuite/gcc.target/powerpc/pr70963.c (working copy) @@ -1,7 +1,8 @@ -/* { dg-do run { target { powerpc64*-*-* && vsx_hw } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ +/* { dg-do run { target powerpc64*-*-* } } */ +/* { dg-require-effective-target p8vector_hw } */ /* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ -/* { dg-options "-maltivec" } */ +/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */ +/* { dg-options "-mcpu=power8" } */ #include <stdlib.h> #include <stdio.h>
Hi, When fixing PR70963, I introduced a test case that didn’t sufficiently constrain the target architecture. Although the built-ins I was testing are available on any platform supporting VSX, the use of vec_all_eq for vector double and vector long long requires at least a POWER8 target. This patch remedies this by ensuring the test will not run unless p8vector support is available. Verified on powerpc64-unknown-linux-gnu and powerpc64le-unknown-linux-gnu. Is this ok for trunk? I will wait a bit longer before deploying to earlier releases… Thanks, Bill 2016-05-11 Bill Schmidt <wschmidt@linux.vnet.ibm.com> * gcc.target/powerpc/pr70963.c: Require at least power8 at both compile and run time.