Message ID | nfpvdt$r7e$1@ger.gmane.org |
---|---|
State | New |
Headers | show |
Stefan Liebler <stli@linux.vnet.ibm.com> writes: > According to the s390-Makefiles, -fpic is used. This patch removes the > overrides of pic-ccflag and the default pic-ccflag = -fPIC in Makeconfig > is used instead to get the R_390_GOTENT relocations in gcrt1.o. Alternatively, you could override -fpic only for gmon-start.os, to keep a possible performance advantage for the rest. Andreas.
On 04/27/2016 12:01 PM, Andreas Schwab wrote: > Stefan Liebler <stli@linux.vnet.ibm.com> writes: > >> According to the s390-Makefiles, -fpic is used. This patch removes the >> overrides of pic-ccflag and the default pic-ccflag = -fPIC in Makeconfig >> is used instead to get the R_390_GOTENT relocations in gcrt1.o. > > Alternatively, you could override -fpic only for gmon-start.os, to keep > a possible performance advantage for the rest. > > Andreas. > As it has no effect for newer architecture levels and for older levels the effect is overall +/-0, I would prefer the switch to -fPIC. Bye Stefan
Commited Bye Stefan On 04/28/2016 08:49 AM, Stefan Liebler wrote: > On 04/27/2016 12:01 PM, Andreas Schwab wrote: >> Stefan Liebler <stli@linux.vnet.ibm.com> writes: >> >>> According to the s390-Makefiles, -fpic is used. This patch removes the >>> overrides of pic-ccflag and the default pic-ccflag = -fPIC in Makeconfig >>> is used instead to get the R_390_GOTENT relocations in gcrt1.o. >> >> Alternatively, you could override -fpic only for gmon-start.os, to keep >> a possible performance advantage for the rest. >> >> Andreas. >> > As it has no effect for newer architecture levels and > for older levels the effect is overall +/-0, > I would prefer the switch to -fPIC. > > Bye > Stefan > >
diff --git a/sysdeps/s390/s390-32/Makefile b/sysdeps/s390/s390-32/Makefile index 057862d..a07f298 100644 --- a/sysdeps/s390/s390-32/Makefile +++ b/sysdeps/s390/s390-32/Makefile @@ -1,5 +1,3 @@ -pic-ccflag = -fpic - ifeq ($(subdir),gmon) sysdep_routines += s390-mcount endif diff --git a/sysdeps/s390/s390-64/Makefile b/sysdeps/s390/s390-64/Makefile index ce4f0c5..5909d1f 100644 --- a/sysdeps/s390/s390-64/Makefile +++ b/sysdeps/s390/s390-64/Makefile @@ -1,5 +1,3 @@ -pic-ccflag = -fpic - ifeq ($(subdir),gmon) sysdep_routines += s390x-mcount endif