| Message ID | 1461507387-2966-1-git-send-email-angelo.compagnucci@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
Hello, On Sun, 24 Apr 2016 16:16:27 +0200, Angelo Compagnucci wrote: > Mono cannot be compiled for sparc32 (v8/leon) so disabling it. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > --- > package/mono/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \ > - BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64) > + BR2_mipsel || BR2_powerpc || BR2_sparc64 || BR2_x86_64) And you're enabling for sparc64 at the same time, which is not explained in your commit log. Also, Waldemar sent a patch one hour before that disables it for SPARC, without enabling it for SPARC64, because it also doesn't build for SPARC64. So I've marked your patch as Rejected in our patch tracking system. Thanks! Thomas
Dear Thomas Petazzoni, 2016-04-24 17:23 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Hello, > > On Sun, 24 Apr 2016 16:16:27 +0200, Angelo Compagnucci wrote: >> Mono cannot be compiled for sparc32 (v8/leon) so disabling it. >> >> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> >> --- >> package/mono/Config.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \ >> - BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64) >> + BR2_mipsel || BR2_powerpc || BR2_sparc64 || BR2_x86_64) > > And you're enabling for sparc64 at the same time, which is not > explained in your commit log. Mmm, right. > > Also, Waldemar sent a patch one hour before that disables it for SPARC, > without enabling it for SPARC64, because it also doesn't build for > SPARC64. The problem is this one: "cannot find crti.o: No such file or directory" Suggesting me the problem is located more in the toolchain than in mono for sparc64, but I have no clue on this. Sincerely, Angelo > > So I've marked your patch as Rejected in our patch tracking system. > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
Hi Angelo, Angelo Compagnucci wrote, > Dear Thomas Petazzoni, > > 2016-04-24 17:23 GMT+02:00 Thomas Petazzoni > <thomas.petazzoni@free-electrons.com>: > > Hello, > > > > On Sun, 24 Apr 2016 16:16:27 +0200, Angelo Compagnucci wrote: > >> Mono cannot be compiled for sparc32 (v8/leon) so disabling it. > >> > >> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > >> --- > >> package/mono/Config.in | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \ > >> - BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64) > >> + BR2_mipsel || BR2_powerpc || BR2_sparc64 || BR2_x86_64) > > > > And you're enabling for sparc64 at the same time, which is not > > explained in your commit log. > > Mmm, right. > > > > > Also, Waldemar sent a patch one hour before that disables it for SPARC, > > without enabling it for SPARC64, because it also doesn't build for > > SPARC64. > > The problem is this one: > > "cannot find crti.o: No such file or directory" > > Suggesting me the problem is located more in the toolchain than in > mono for sparc64, but I have no clue on this. I had other issues regarding ucontext.h struct mismatches. best regards Waldemar
diff --git a/package/mono/Config.in b/package/mono/Config.in index cf18a03..a42b14b 100644 --- a/package/mono/Config.in +++ b/package/mono/Config.in @@ -1,7 +1,7 @@ config BR2_PACKAGE_MONO_ARCH_SUPPORTS bool default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \ - BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64) + BR2_mipsel || BR2_powerpc || BR2_sparc64 || BR2_x86_64) config BR2_PACKAGE_MONO bool "mono"
Mono cannot be compiled for sparc32 (v8/leon) so disabling it. Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> --- package/mono/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)