| Message ID | 1460658919-4965-3-git-send-email-david@lechnology.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hello. On 4/14/2016 9:35 PM, David Lechner wrote: > Device tree binding for new phy-da8xx-usb driver. > > Signed-off-by: David Lechner <david@lechnology.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > > v4 changes: > > * swapped order of usb20 and usb11 to be in logical order of reg address. > > .../devicetree/bindings/phy/phy-da8xx-usb.txt | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt > new file mode 100644 > index 0000000..bead185 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt > @@ -0,0 +1,40 @@ > +TI DaVinci DA8xx USB PHY DA8xx is not DaVinci, please omit this. > + > +Required properties: > + - compatible: must be "ti,da830-usbphy". > + - #phy-cells: must be 1. > + > +This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG > +controllers on DA8xx SoCs. Consumers of this device should use index 0 for > +the USB 2.0 phy device and index 1 for the USB 1.1 phy device. Not indices 2 and 1 already? > +It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon" > +to access the CFGCHIP2 register. > + > +Example: > + > + cfgchip: cfgchip@1417c { > + compatible = "ti,da830-cfgchip", "syscon"; > + reg = <0x1417c 0x14>; > + }; > + > + usbphy: usbphy { Name it "usb-phy" please, consistent to what ePAPR has mandated for Ethernet PHYs. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/15/2016 05:48 AM, Sergei Shtylyov wrote: > On 4/14/2016 9:35 PM, David Lechner wrote: > >> Device tree binding for new phy-da8xx-usb driver. >> >> Signed-off-by: David Lechner <david@lechnology.com> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> >> v4 changes: >> >> * swapped order of usb20 and usb11 to be in logical order of reg address. >> >> .../devicetree/bindings/phy/phy-da8xx-usb.txt | 40 >> ++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >> b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >> new file mode 100644 >> index 0000000..bead185 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >> @@ -0,0 +1,40 @@ >> +TI DaVinci DA8xx USB PHY > > DA8xx is not DaVinci, please omit this. Just to be sure, you mean omit "DaVinci"? > >> + >> +Required properties: >> + - compatible: must be "ti,da830-usbphy". >> + - #phy-cells: must be 1. >> + >> +This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG >> +controllers on DA8xx SoCs. Consumers of this device should use index >> 0 for >> +the USB 2.0 phy device and index 1 for the USB 1.1 phy device. > > Not indices 2 and 1 already? I changed this to reflect the TRM. USB0PHY = USB 2.0 and USB1PHY = USB 1.1 > >> + usbphy: usbphy { > > Name it "usb-phy" please, consistent to what ePAPR has mandated for > Ethernet PHYs. Ack. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/15/2016 07:13 PM, David Lechner wrote: >>> Device tree binding for new phy-da8xx-usb driver. >>> >>> Signed-off-by: David Lechner <david@lechnology.com> >>> Acked-by: Rob Herring <robh@kernel.org> >>> --- >>> >>> v4 changes: >>> >>> * swapped order of usb20 and usb11 to be in logical order of reg address. >>> >>> .../devicetree/bindings/phy/phy-da8xx-usb.txt | 40 >>> ++++++++++++++++++++++ >>> 1 file changed, 40 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >>> >>> diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >>> b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >>> new file mode 100644 >>> index 0000000..bead185 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt >>> @@ -0,0 +1,40 @@ >>> +TI DaVinci DA8xx USB PHY >> >> DA8xx is not DaVinci, please omit this. > > Just to be sure, you mean omit "DaVinci"? Exactly. It would be better to mention OMAP-L1x instead. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt new file mode 100644 index 0000000..bead185 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt @@ -0,0 +1,40 @@ +TI DaVinci DA8xx USB PHY + +Required properties: + - compatible: must be "ti,da830-usbphy". + - #phy-cells: must be 1. + +This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG +controllers on DA8xx SoCs. Consumers of this device should use index 0 for +the USB 2.0 phy device and index 1 for the USB 1.1 phy device. + +It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon" +to access the CFGCHIP2 register. + +Example: + + cfgchip: cfgchip@1417c { + compatible = "ti,da830-cfgchip", "syscon"; + reg = <0x1417c 0x14>; + }; + + usbphy: usbphy { + compatible = "ti,da830-usbphy"; + #phy-cells = <1>; + }; + + usb20: usb@200000 { + compatible = "ti,da830-musb"; + reg = <0x200000 0x1000>; + interrupts = <58>; + phys = <&usbphy 0>; + phy-names = "usbphy"; + }; + + usb11: usb@225000 { + compatible = "ti,da830-ohci"; + reg = <0x225000 0x1000>; + interrupts = <59>; + phys = <&usbphy 1>; + phy-names = "usbphy"; + };