mbox

[GIT,PULL] Renesas ARM Based SoC Fixes for v4.6

Message ID cover.1460339328.git.horms+renesas@verge.net.au
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes-for-v4.6

Message

Simon Horman April 11, 2016, 1:52 a.m. UTC
Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM based SoC fixes for v4.6.


Allow serial to work once again on the Porter board (Revision B) which
does not have the oscillator in question mounted.


The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca:

  Linux 4.6-rc1 (2016-03-26 16:03:24 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes-for-v4.6

for you to fetch changes up to e885767418bff0c591cc1e45babdd25d91b4a795:

  Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins" (2016-04-08 15:56:28 +0900)

----------------------------------------------------------------
Renesas ARM Based SoC Fixes for v4.6

* Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"

----------------------------------------------------------------
Sjoerd Simons (1):
      Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"

 arch/arm/boot/dts/r8a7791-porter.dts | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Geert Uytterhoeven April 11, 2016, 7:11 a.m. UTC | #1
Hi Simon,

On Mon, Apr 11, 2016 at 3:52 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
>
> Please consider these Renesas ARM based SoC fixes for v4.6.
>
>
> Allow serial to work once again on the Porter board (Revision B) which
> does not have the oscillator in question mounted.

Have you tested this on Porter?

I believe there's another change to be made for this revert to actually work,
cfr. "[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks"
(https://lkml.org/lkml/2016/4/6/350)

> The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca:
>
>   Linux 4.6-rc1 (2016-03-26 16:03:24 -0700)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes-for-v4.6
>
> for you to fetch changes up to e885767418bff0c591cc1e45babdd25d91b4a795:
>
>   Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins" (2016-04-08 15:56:28 +0900)
>
> ----------------------------------------------------------------
> Renesas ARM Based SoC Fixes for v4.6
>
> * Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"
>
> ----------------------------------------------------------------
> Sjoerd Simons (1):
>       Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Simon Horman April 11, 2016, 11:02 p.m. UTC | #2
On Mon, Apr 11, 2016 at 09:11:19AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Apr 11, 2016 at 3:52 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Hi Olof, Hi Kevin, Hi Arnd,
> >
> > Please consider these Renesas ARM based SoC fixes for v4.6.
> >
> >
> > Allow serial to work once again on the Porter board (Revision B) which
> > does not have the oscillator in question mounted.
> 
> Have you tested this on Porter?

I don't have working access to a porter at this time.

> I believe there's another change to be made for this revert to actually work,
> cfr. "[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks"
> (https://lkml.org/lkml/2016/4/6/350)

Ok, understood.

Could someone verify that?
Simon Horman April 18, 2016, 4:12 a.m. UTC | #3
Hi Geert, Hi Sjoerd,

On Tue, Apr 12, 2016 at 08:02:54AM +0900, Simon Horman wrote:
> On Mon, Apr 11, 2016 at 09:11:19AM +0200, Geert Uytterhoeven wrote:
> > Hi Simon,
> > 
> > On Mon, Apr 11, 2016 at 3:52 AM, Simon Horman
> > <horms+renesas@verge.net.au> wrote:
> > > Hi Olof, Hi Kevin, Hi Arnd,
> > >
> > > Please consider these Renesas ARM based SoC fixes for v4.6.
> > >
> > >
> > > Allow serial to work once again on the Porter board (Revision B) which
> > > does not have the oscillator in question mounted.
> > 
> > Have you tested this on Porter?
> 
> I don't have working access to a porter at this time.
> 
> > I believe there's another change to be made for this revert to actually work,
> > cfr. "[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks"
> > (https://lkml.org/lkml/2016/4/6/350)
> 
> Ok, understood.
> 
> Could someone verify that?

I have added "ARM: dts: r8a7791: Don't disable referenced optional clocks"
to the fixes-for-v4.6 branch and plan to push it in a fresh renesas-next
tag a little later today.

I would appreciate any review and/or testing on porter of that branch.

Thanks!
Geert Uytterhoeven April 19, 2016, 7:23 a.m. UTC | #4
Hi Simon,

On Mon, Apr 18, 2016 at 6:12 AM, Simon Horman <horms@verge.net.au> wrote:
> On Tue, Apr 12, 2016 at 08:02:54AM +0900, Simon Horman wrote:
>> On Mon, Apr 11, 2016 at 09:11:19AM +0200, Geert Uytterhoeven wrote:
>> > On Mon, Apr 11, 2016 at 3:52 AM, Simon Horman
>> > <horms+renesas@verge.net.au> wrote:
>> > > Hi Olof, Hi Kevin, Hi Arnd,
>> > >
>> > > Please consider these Renesas ARM based SoC fixes for v4.6.
>> > >
>> > >
>> > > Allow serial to work once again on the Porter board (Revision B) which
>> > > does not have the oscillator in question mounted.
>> >
>> > Have you tested this on Porter?
>>
>> I don't have working access to a porter at this time.
>>
>> > I believe there's another change to be made for this revert to actually work,
>> > cfr. "[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks"
>> > (https://lkml.org/lkml/2016/4/6/350)
>>
>> Ok, understood.
>>
>> Could someone verify that?
>
> I have added "ARM: dts: r8a7791: Don't disable referenced optional clocks"
> to the fixes-for-v4.6 branch and plan to push it in a fresh renesas-next
> tag a little later today.

Thanks!

I would queue

    ARM: dts: r8a7791: Don't disable referenced optional clocks

before

    Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"

to preserve bisectability. So please reorder these two commits.

> I would appreciate any review and/or testing on porter of that branch.

I've provided my Reviewed-By in the original thread.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Sjoerd Simons April 19, 2016, 9:12 a.m. UTC | #5
Hey Simon,
On Mon, 2016-04-18 at 14:12 +1000, Simon Horman wrote:
> Hi Geert, Hi Sjoerd,
> 
> On Tue, Apr 12, 2016 at 08:02:54AM +0900, Simon Horman wrote:
> > 
> > On Mon, Apr 11, 2016 at 09:11:19AM +0200, Geert Uytterhoeven wrote:
> > > 
> > > Hi Simon,
> > > 
> > > On Mon, Apr 11, 2016 at 3:52 AM, Simon Horman
> > > <horms+renesas@verge.net.au> wrote:
> > > > 
> > > > Hi Olof, Hi Kevin, Hi Arnd,
> > > > 
> > > > Please consider these Renesas ARM based SoC fixes for v4.6.
> > > > 
> > > > 
> > > > Allow serial to work once again on the Porter board (Revision
> > > > B) which
> > > > does not have the oscillator in question mounted.
> > > Have you tested this on Porter?
> > I don't have working access to a porter at this time.
> > 
> > > 
> > > I believe there's another change to be made for this revert to
> > > actually work,
> > > cfr. "[PATCH] ARM: dts: r8a7791: Don't disable referenced
> > > optional clocks"
> > > (https://lkml.org/lkml/2016/4/6/350)
> > Ok, understood.
> > 
> > Could someone verify that?
> I have added "ARM: dts: r8a7791: Don't disable referenced optional
> clocks"
> to the fixes-for-v4.6 branch and plan to push it in a fresh renesas-
> next
> tag a little later today.
> 
> I would appreciate any review and/or testing on porter of that
branch.

I've tested this branch (top commit 3d7277614d29) on a Porter revision
B board and can confirm the serial console works as expected.

Feel free to add:
  Tested-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Simon Horman April 19, 2016, 10:53 p.m. UTC | #6
On Tue, Apr 19, 2016 at 09:23:10AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Apr 18, 2016 at 6:12 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Apr 12, 2016 at 08:02:54AM +0900, Simon Horman wrote:
> >> On Mon, Apr 11, 2016 at 09:11:19AM +0200, Geert Uytterhoeven wrote:
> >> > On Mon, Apr 11, 2016 at 3:52 AM, Simon Horman
> >> > <horms+renesas@verge.net.au> wrote:
> >> > > Hi Olof, Hi Kevin, Hi Arnd,
> >> > >
> >> > > Please consider these Renesas ARM based SoC fixes for v4.6.
> >> > >
> >> > >
> >> > > Allow serial to work once again on the Porter board (Revision B) which
> >> > > does not have the oscillator in question mounted.
> >> >
> >> > Have you tested this on Porter?
> >>
> >> I don't have working access to a porter at this time.
> >>
> >> > I believe there's another change to be made for this revert to actually work,
> >> > cfr. "[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks"
> >> > (https://lkml.org/lkml/2016/4/6/350)
> >>
> >> Ok, understood.
> >>
> >> Could someone verify that?
> >
> > I have added "ARM: dts: r8a7791: Don't disable referenced optional clocks"
> > to the fixes-for-v4.6 branch and plan to push it in a fresh renesas-next
> > tag a little later today.
> 
> Thanks!
> 
> I would queue
> 
>     ARM: dts: r8a7791: Don't disable referenced optional clocks
> 
> before
> 
>     Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"
> 
> to preserve bisectability. So please reorder these two commits.

Thanks, I have reordered the commits as you suggest.

> > I would appreciate any review and/or testing on porter of that branch.
> 
> I've provided my Reviewed-By in the original thread.

Thanks, got it.
Simon Horman April 19, 2016, 10:54 p.m. UTC | #7
On Tue, Apr 19, 2016 at 11:12:03AM +0200, Sjoerd Simons wrote:
> Hey Simon,
> On Mon, 2016-04-18 at 14:12 +1000, Simon Horman wrote:
> > Hi Geert, Hi Sjoerd,
> > 
> > On Tue, Apr 12, 2016 at 08:02:54AM +0900, Simon Horman wrote:
> > > 
> > > On Mon, Apr 11, 2016 at 09:11:19AM +0200, Geert Uytterhoeven wrote:
> > > > 
> > > > Hi Simon,
> > > > 
> > > > On Mon, Apr 11, 2016 at 3:52 AM, Simon Horman
> > > > <horms+renesas@verge.net.au> wrote:
> > > > > 
> > > > > Hi Olof, Hi Kevin, Hi Arnd,
> > > > > 
> > > > > Please consider these Renesas ARM based SoC fixes for v4.6.
> > > > > 
> > > > > 
> > > > > Allow serial to work once again on the Porter board (Revision
> > > > > B) which
> > > > > does not have the oscillator in question mounted.
> > > > Have you tested this on Porter?
> > > I don't have working access to a porter at this time.
> > > 
> > > > 
> > > > I believe there's another change to be made for this revert to
> > > > actually work,
> > > > cfr. "[PATCH] ARM: dts: r8a7791: Don't disable referenced
> > > > optional clocks"
> > > > (https://lkml.org/lkml/2016/4/6/350)
> > > Ok, understood.
> > > 
> > > Could someone verify that?
> > I have added "ARM: dts: r8a7791: Don't disable referenced optional
> > clocks"
> > to the fixes-for-v4.6 branch and plan to push it in a fresh renesas-
> > next
> > tag a little later today.
> > 
> > I would appreciate any review and/or testing on porter of that
> branch.
> 
> I've tested this branch (top commit 3d7277614d29) on a Porter revision
> B board and can confirm the serial console works as expected.
> 
> Feel free to add:
>   Tested-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Thanks, that is really helpful!

I think I will leave out the extra tag as the patches
in question are already signed off by you.