| Message ID | 1459508173-22777-3-git-send-email-harshitha.ramamurthy@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Jeff Kirsher |
| Headers | show |
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On > Behalf Of Harshitha Ramamurthy > Sent: Friday, April 01, 2016 3:56 AM > To: intel-wired-lan@lists.osuosl.org > Subject: [Intel-wired-lan] [v3 next PATCH S32 02/13] i40e: Leave debug_mask > cleared at init > > From: Shannon Nelson <shannon.nelson@intel.com> > > Don't set our internal debug_mask at startup unless we get specific signal to > from the debug module parameter. > > This should take care of the issue with all the device capabilities getting > printed even when we hadn't asked for the debug info. > > Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> > Change-ID: I7fbc6bd8b11ed9b0631ec018ff36015a04100b6c > --- > Testing Hints: > Force a PFR and see that the extra debug message don't show up > > enable debug with > ethtool -i <ethX> msglvl 0xf0000001 > then force a PFR, and see that the debug message *do* show up > > disable debug with > ethtool -i <ethX> msglvl 0xf0000000 > then force a PFR, and see that the debug message do *not* show up > > drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - > 1 file changed, 1 deletion(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Debug messages only show after debug mode is enabled
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index d6147f8..86abd08 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -8438,7 +8438,6 @@ static int i40e_sw_init(struct i40e_pf *pf) pf->msg_enable = netif_msg_init(I40E_DEFAULT_MSG_ENABLE, (NETIF_MSG_DRV|NETIF_MSG_PROBE|NETIF_MSG_LINK)); - pf->hw.debug_mask = pf->msg_enable | I40E_DEBUG_DIAG; if (debug != -1 && debug != I40E_DEFAULT_MSG_ENABLE) { if (I40E_DEBUG_USER & debug) pf->hw.debug_mask = debug;