| Message ID | 1276060930-15697-1-git-send-email-timo.teras@iki.fi |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Timo Teräs <timo.teras@iki.fi> : > Realtek confirmed that a 20us delay is needed after mdio_read and > mdio_write operations. Reduce the delay in mdio_write, and add it > to mdio_read too. Also add a comment that the 20us is from hw specs. > > Signed-off-by: Timo Teräs <timo.teras@iki.fi> Acked-off-by: Francois Romieu <romieu@fr.zoreil.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Francois Romieu <romieu@fr.zoreil.com> Date: Wed, 9 Jun 2010 08:18:25 +0200 > Timo Teräs <timo.teras@iki.fi> : >> Realtek confirmed that a 20us delay is needed after mdio_read and >> mdio_write operations. Reduce the delay in mdio_write, and add it >> to mdio_read too. Also add a comment that the 20us is from hw specs. >> >> Signed-off-by: Timo Teräs <timo.teras@iki.fi> > > Acked-off-by: Francois Romieu <romieu@fr.zoreil.com> I think you meant "Acked-by: " :-) I fixed this and committed Timo's patch, thanks everyone! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 03a8318..96b6cfb 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -560,10 +560,10 @@ static void mdio_write(void __iomem *ioaddr, int reg_addr, int value) udelay(25); } /* - * Some configurations require a small delay even after the write - * completed indication or the next write might fail. + * According to hardware specs a 20us delay is required after write + * complete indication, but before sending next command. */ - udelay(25); + udelay(20); } static int mdio_read(void __iomem *ioaddr, int reg_addr) @@ -583,6 +583,12 @@ static int mdio_read(void __iomem *ioaddr, int reg_addr) } udelay(25); } + /* + * According to hardware specs a 20us delay is required after read + * complete indication, but before sending next command. + */ + udelay(20); + return value; }
Realtek confirmed that a 20us delay is needed after mdio_read and mdio_write operations. Reduce the delay in mdio_write, and add it to mdio_read too. Also add a comment that the 20us is from hw specs. Signed-off-by: Timo Teräs <timo.teras@iki.fi> Cc: Francois Romieu <romieu@fr.zoreil.com> Cc: Hayeswang <hayeswang@realtek.com> --- drivers/net/r8169.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)