diff mbox

[ovs-dev,3/3] NEWS: dpdk port hotplug is now supported

Message ID 1459155142-3762-3-git-send-email-mauricio.vasquezbernal@studenti.polito.it
State Superseded
Headers show

Commit Message

Mauricio Vásquez March 28, 2016, 8:52 a.m. UTC
Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>
---
 NEWS | 1 +
 1 file changed, 1 insertion(+)

Comments

Justin Pettit March 28, 2016, 9:43 p.m. UTC | #1
> On Mar 28, 2016, at 1:52 AM, Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it> wrote:
> 
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>
> ---
> NEWS | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/NEWS b/NEWS
> index ea7f3a1..2ba8659 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -26,6 +26,7 @@ Post-v2.5.0
>        assignment.
>      * Type of log messages from PMD threads changed from INFO to DBG.
>      * QoS functionality with sample egress-policer implementation.
> +     * Port Hotplug is now supported.
>    - ovs-benchmark: This utility has been removed due to lack of use and
>      bitrot.
>    - ovs-appctl:

This isn't a full review, but we normally add documentation, introduce tests, update NEWS alongside the code that adds it.

--Justin
Mauricio Vásquez March 29, 2016, 1 p.m. UTC | #2
Right, I'll wait for a review and then I'll send a V2 with all the patches
in one.

On Mon, Mar 28, 2016 at 11:43 PM, Justin Pettit <jpettit@ovn.org> wrote:

>
> > On Mar 28, 2016, at 1:52 AM, Mauricio Vasquez B <
> mauricio.vasquezbernal@studenti.polito.it> wrote:
> >
> > Signed-off-by: Mauricio Vasquez B <
> mauricio.vasquezbernal@studenti.polito.it>
> > ---
> > NEWS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/NEWS b/NEWS
> > index ea7f3a1..2ba8659 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -26,6 +26,7 @@ Post-v2.5.0
> >        assignment.
> >      * Type of log messages from PMD threads changed from INFO to DBG.
> >      * QoS functionality with sample egress-policer implementation.
> > +     * Port Hotplug is now supported.
> >    - ovs-benchmark: This utility has been removed due to lack of use and
> >      bitrot.
> >    - ovs-appctl:
>
> This isn't a full review, but we normally add documentation, introduce
> tests, update NEWS alongside the code that adds it.
>
> --Justin
>
>
>
diff mbox

Patch

diff --git a/NEWS b/NEWS
index ea7f3a1..2ba8659 100644
--- a/NEWS
+++ b/NEWS
@@ -26,6 +26,7 @@  Post-v2.5.0
        assignment.
      * Type of log messages from PMD threads changed from INFO to DBG.
      * QoS functionality with sample egress-policer implementation.
+     * Port Hotplug is now supported.
    - ovs-benchmark: This utility has been removed due to lack of use and
      bitrot.
    - ovs-appctl: