| Message ID | 1458027237-8926-4-git-send-email-ruscur@russell.cc |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, 15 Mar 2016 18:33:53 Russell Currey wrote: > If npu.h were to be used outside of hw/*, it fails to find the out_be64 Well more correctly anything that doesn't already include io.h :) > symbol which is defined in io.h. Fix that up by making it a requirement > of npu.h. Acked-By: Alistair Popple <alistair@popple.id.au> > Signed-off-by: Russell Currey <ruscur@russell.cc> > --- > include/npu.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/npu.h b/include/npu.h > index 389b732..0b2d984 100644 > --- a/include/npu.h > +++ b/include/npu.h > @@ -17,6 +17,8 @@ > #ifndef __NPU_H > #define __NPU_H > > +#include <io.h> > + > /* Number of PEs supported */ > #define NPU_NUM_OF_PES 4 > >
On Thu, 2016-03-17 at 16:08 +1100, Alistair Popple wrote: > On Tue, 15 Mar 2016 18:33:53 Russell Currey wrote: > > > > If npu.h were to be used outside of hw/*, it fails to find the out_be64 > Well more correctly anything that doesn't already include io.h :) Heh, that makes more sense. I'll rewrite the message in v2. > > > > > symbol which is defined in io.h. Fix that up by making it a > > requirement > > of npu.h. > Acked-By: Alistair Popple <alistair@popple.id.au> > > > > > Signed-off-by: Russell Currey <ruscur@russell.cc> > > --- > > include/npu.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/npu.h b/include/npu.h > > index 389b732..0b2d984 100644 > > --- a/include/npu.h > > +++ b/include/npu.h > > @@ -17,6 +17,8 @@ > > #ifndef __NPU_H > > #define __NPU_H > > > > +#include <io.h> > > + > > /* Number of PEs supported */ > > #define NPU_NUM_OF_PES 4 > > > >
diff --git a/include/npu.h b/include/npu.h index 389b732..0b2d984 100644 --- a/include/npu.h +++ b/include/npu.h @@ -17,6 +17,8 @@ #ifndef __NPU_H #define __NPU_H +#include <io.h> + /* Number of PEs supported */ #define NPU_NUM_OF_PES 4
If npu.h were to be used outside of hw/*, it fails to find the out_be64 symbol which is defined in io.h. Fix that up by making it a requirement of npu.h. Signed-off-by: Russell Currey <ruscur@russell.cc> --- include/npu.h | 2 ++ 1 file changed, 2 insertions(+)