| Message ID | 20100530122606.GC1146@host-a-55.ustcsz.edu.cn |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 05/30/2010 08:26 AM, Junchang Wang wrote: > readl() returns a 32-bit integer on all platforms. > There is no need to cast its return value. > > Signed-off-by: Junchang Wang<junchangwang@gmail.com> > --- > drivers/net/r8169.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c > index 217e709..ca93cdf 100644 > --- a/drivers/net/r8169.c > +++ b/drivers/net/r8169.c > @@ -88,7 +88,7 @@ static const int multicast_filter_limit = 32; > #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg)) > #define RTL_R8(reg) readb (ioaddr + (reg)) > #define RTL_R16(reg) readw (ioaddr + (reg)) > -#define RTL_R32(reg) ((unsigned long) readl (ioaddr + (reg))) > +#define RTL_R32(reg) readl (ioaddr + (reg)) Ditto last email: have you verified this matches all arch's definition of readl()? Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Junchang Wang <junchangwang@gmail.com> Date: Sun, 30 May 2010 20:26:07 +0800 > readl() returns a 32-bit integer on all platforms. > There is no need to cast its return value. > > Signed-off-by: Junchang Wang <junchangwang@gmail.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 217e709..ca93cdf 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -88,7 +88,7 @@ static const int multicast_filter_limit = 32; #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg)) #define RTL_R8(reg) readb (ioaddr + (reg)) #define RTL_R16(reg) readw (ioaddr + (reg)) -#define RTL_R32(reg) ((unsigned long) readl (ioaddr + (reg))) +#define RTL_R32(reg) readl (ioaddr + (reg)) enum mac_version { RTL_GIGA_MAC_NONE = 0x00,
readl() returns a 32-bit integer on all platforms. There is no need to cast its return value. Signed-off-by: Junchang Wang <junchangwang@gmail.com> --- drivers/net/r8169.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html