diff mbox

mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'

Message ID 1457147553-71596-1-git-send-email-computersforpeace@gmail.com
State Superseded
Headers show

Commit Message

Brian Norris March 5, 2016, 3:12 a.m. UTC 
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/nand/pxa3xx_nand.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Robert Jarzmik March 5, 2016, 8:34 a.m. UTC | #1 
Brian Norris <computersforpeace@gmail.com> writes:

> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Hi Brian,

> @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
>  			ret = -ENXIO;
>  			goto fail_disable_clk;
>  		}
> -		info->drcmr_cmd = r->start;
>  	}
If you kill this field, why not kill also this block just above ?
		r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
		if (r == NULL) {
			dev_err(&pdev->dev,
				"no resource defined for cmd DMA\n");
			ret = -ENXIO;
			goto fail_disable_clk;
		}

Cheers.
diff mbox

Patch

diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index f100c4da0423..a60c413c8d7f 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -211,7 +211,6 @@  struct pxa3xx_nand_info {
 	struct dma_chan		*dma_chan;
 	dma_cookie_t		dma_cookie;
 	int			drcmr_dat;
-	int			drcmr_cmd;
 
 	unsigned char		*data_buff;
 	unsigned char		*oob_buff;
@@ -1812,7 +1811,6 @@  static int alloc_nand_resource(struct platform_device *pdev)
 			ret = -ENXIO;
 			goto fail_disable_clk;
 		}
-		info->drcmr_cmd = r->start;
 	}
 
 	irq = platform_get_irq(pdev, 0);