Message ID | 1456264228-19851-1-git-send-email-angelo.compagnucci@gmail.com |
---|---|
State | Superseded |
Headers | show |
On 02/23/16 22:50, Angelo Compagnucci wrote: > * This patch solves installation problems with monoposixhelper This description should be better, e.g. taking part of the bug description. libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path and file may exist on my building machine, but not on the target. Fixes bug #8651. > * Fixes https://bugs.busybox.net/show_bug.cgi?id=8651 > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > --- > Changelog: > > v2 -> v3: > The patch was based on mono master and not on mono 4.2.2.30. > This patch is now based on mono 4.2.2.30. > This patch was tested on br_next. > > v1 -> v2: > * Added SoB and description to patch > > > ....in-fixing-wrong-MonoPosixHelper-location.patch | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch > > diff --git a/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch b/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch > new file mode 100644 > index 0000000..6ebb802 > --- /dev/null > +++ b/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch > @@ -0,0 +1,28 @@ > +From 76aa4fb62a433e61dc35eefcc3077f0463182d2f Mon Sep 17 00:00:00 2001 > +From: Angelo Compagnucci <angelo.compagnucci@gmail.com> > +Date: Tue, 23 Feb 2016 22:43:39 +0100 > +Subject: [PATCH] config.in: fixing wrong MonoPosixHelper location > + > +This patch remove a wrong prefix for libMonoPosixHelper > + > +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > +--- > + data/config.in | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/data/config.in b/data/config.in > +index b760176..41495b9 100644 > +--- a/data/config.in > ++++ b/data/config.in > +@@ -10,7 +10,7 @@ > + <dllmap dll="i:odbc32.dll" target="libiodbc.dylib" os="osx"/> > + <dllmap dll="oci" target="libclntsh@libsuffix@" os="!windows"/> > + <dllmap dll="db2cli" target="libdb2_36@libsuffix@" os="!windows"/> > +- <dllmap dll="MonoPosixHelper" target="@prefix@/@reloc_libdir@/libMonoPosixHelper@libsuffix@" os="!windows" /> > ++ <dllmap dll="MonoPosixHelper" target="libMonoPosixHelper@libsuffix@" os="!windows" /> So 6b5f6dd0434b66062110cf764688975ecfed646f doesn't fix it? That would mean that mono_assembly_getrootdir() is wrong, which is bound to lead to other problems... Regards, Arnout > + <dllmap dll="i:msvcrt" target="@LIBC@" os="!windows"/> > + <dllmap dll="i:msvcrt.dll" target="@LIBC@" os="!windows"/> > + <dllmap dll="sqlite" target="@SQLITE@" os="!windows"/> > +-- > +1.9.1 > + >
Dear Arnout Vandecappelle, 2016-02-23 23:19 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: > On 02/23/16 22:50, Angelo Compagnucci wrote: >> * This patch solves installation problems with monoposixhelper > > This description should be better, e.g. taking part of the bug description. > > libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path > and file may exist on my building machine, but not on the target. > > Fixes bug #8651. Have I to resend? > >> * Fixes https://bugs.busybox.net/show_bug.cgi?id=8651 >> >> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> >> --- >> Changelog: >> >> v2 -> v3: >> The patch was based on mono master and not on mono 4.2.2.30. >> This patch is now based on mono 4.2.2.30. >> This patch was tested on br_next. >> >> v1 -> v2: >> * Added SoB and description to patch >> >> >> ....in-fixing-wrong-MonoPosixHelper-location.patch | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch >> >> diff --git a/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch b/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch >> new file mode 100644 >> index 0000000..6ebb802 >> --- /dev/null >> +++ b/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch >> @@ -0,0 +1,28 @@ >> +From 76aa4fb62a433e61dc35eefcc3077f0463182d2f Mon Sep 17 00:00:00 2001 >> +From: Angelo Compagnucci <angelo.compagnucci@gmail.com> >> +Date: Tue, 23 Feb 2016 22:43:39 +0100 >> +Subject: [PATCH] config.in: fixing wrong MonoPosixHelper location >> + >> +This patch remove a wrong prefix for libMonoPosixHelper >> + >> +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> >> +--- >> + data/config.in | 2 +- >> + 1 file changed, 1 insertion(+), 1 deletion(-) >> + >> +diff --git a/data/config.in b/data/config.in >> +index b760176..41495b9 100644 >> +--- a/data/config.in >> ++++ b/data/config.in >> +@@ -10,7 +10,7 @@ >> + <dllmap dll="i:odbc32.dll" target="libiodbc.dylib" os="osx"/> >> + <dllmap dll="oci" target="libclntsh@libsuffix@" os="!windows"/> >> + <dllmap dll="db2cli" target="libdb2_36@libsuffix@" os="!windows"/> >> +- <dllmap dll="MonoPosixHelper" target="@prefix@/@reloc_libdir@/libMonoPosixHelper@libsuffix@" os="!windows" /> >> ++ <dllmap dll="MonoPosixHelper" target="libMonoPosixHelper@libsuffix@" os="!windows" /> > > So 6b5f6dd0434b66062110cf764688975ecfed646f doesn't fix it? That would mean > that mono_assembly_getrootdir() is wrong, which is bound to lead to other > problems... That commit is not included in mono-4.2.2.30, could you explain better? Do you think I have to backport that patch from master? Honestly, if the released a buggy version, we should wait a correct one. I'm reactive about upgrading mono version in buildroot! Sincerely, Angelo > > > Regards, > Arnout > >> + <dllmap dll="i:msvcrt" target="@LIBC@" os="!windows"/> >> + <dllmap dll="i:msvcrt.dll" target="@LIBC@" os="!windows"/> >> + <dllmap dll="sqlite" target="@SQLITE@" os="!windows"/> >> +-- >> +1.9.1 >> + >> > > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
On 02/23/16 23:29, Angelo Compagnucci wrote: > Dear Arnout Vandecappelle, > > 2016-02-23 23:19 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: >> On 02/23/16 22:50, Angelo Compagnucci wrote: >>> * This patch solves installation problems with monoposixhelper >> >> This description should be better, e.g. taking part of the bug description. >> >> libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path >> and file may exist on my building machine, but not on the target. >> >> Fixes bug #8651. > > Have I to resend? Depends on the outcome of the discussion below. [snip] >> >> So 6b5f6dd0434b66062110cf764688975ecfed646f doesn't fix it? That would mean >> that mono_assembly_getrootdir() is wrong, which is bound to lead to other >> problems... > > That commit is not included in mono-4.2.2.30, could you explain better? That commit is from the 4.3 branch (I think, I haven't made a full clone, just browsed on github). > Do you think I have to backport that patch from master? Honestly, if > the released a buggy version, we should wait a correct one. I'm > reactive about upgrading mono version in buildroot! That commit is dated July 23, 2015, so we can wait a long time still :-) But I asked the question because your original patch v1 was made on top of the 4.3 (or rather, master) branch. So there are two possibilities: either it's still broken on master, or you never actually tested the master branch before you submitted the patch upstream. - If it is not broken on master, then it's better to backport commit 6b5f6dd0434b66062110cf764688975ecfed646f from master. - If it is still broken on master, then your patch is good for buildroot, but I fear there will be other issues lurking in the shadows because it means the mono_assembly_getrootdir() function doesn't work correctly in buildroot. Regards, Arnout [snip]
Dear Arnout Vandecappelle, 2016-02-24 21:34 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: > On 02/23/16 23:29, Angelo Compagnucci wrote: >> Dear Arnout Vandecappelle, >> >> 2016-02-23 23:19 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: >>> On 02/23/16 22:50, Angelo Compagnucci wrote: >>>> * This patch solves installation problems with monoposixhelper >>> >>> This description should be better, e.g. taking part of the bug description. >>> >>> libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path >>> and file may exist on my building machine, but not on the target. >>> >>> Fixes bug #8651. >> >> Have I to resend? > > Depends on the outcome of the discussion below. > > [snip] >>> >>> So 6b5f6dd0434b66062110cf764688975ecfed646f doesn't fix it? That would mean >>> that mono_assembly_getrootdir() is wrong, which is bound to lead to other >>> problems... >> >> That commit is not included in mono-4.2.2.30, could you explain better? > > That commit is from the 4.3 branch (I think, I haven't made a full clone, just > browsed on github). > >> Do you think I have to backport that patch from master? Honestly, if >> the released a buggy version, we should wait a correct one. I'm >> reactive about upgrading mono version in buildroot! > > That commit is dated July 23, 2015, so we can wait a long time still :-) > > But I asked the question because your original patch v1 was made on top of the > 4.3 (or rather, master) branch. So there are two possibilities: either it's > still broken on master, or you never actually tested the master branch before > you submitted the patch upstream. > > - If it is not broken on master, then it's better to backport commit > 6b5f6dd0434b66062110cf764688975ecfed646f from master. > > - If it is still broken on master, then your patch is good for buildroot, but I > fear there will be other issues lurking in the shadows because it means the > mono_assembly_getrootdir() function doesn't work correctly in buildroot. The matter it's really simple. I submitted a wrong patch. You can find the original (and working patch) attached on https://bugs.busybox.net/show_bug.cgi?id=8651 . When I prepared the patch for sending in ML I did the mistake of rebasing on master, instead of checking out the version 4.2.2.30. I can assure the patch I submitted solves the problem. In mono upstream, developers did a refactor of that part and the patch I previously sent (for master) is simply wrong, cause the refactor already solves the problem. Indeed I closed the issue on mono github. As you said previously, mono has a really slow release process, with many months of delay, so I think we should stick with this latter patch I sent. When the new release 4.3.X will be out, I will promptly bump to that version and remove the unneeded patch. Sincerely, Angelo > > Regards, > Arnout > > [snip] > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
On 02/24/16 21:46, Angelo Compagnucci wrote: > Dear Arnout Vandecappelle, > > 2016-02-24 21:34 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: >> On 02/23/16 23:29, Angelo Compagnucci wrote: >>> Dear Arnout Vandecappelle, >>> >>> 2016-02-23 23:19 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: >>>> On 02/23/16 22:50, Angelo Compagnucci wrote: >>>>> * This patch solves installation problems with monoposixhelper >>>> >>>> This description should be better, e.g. taking part of the bug description. >>>> >>>> libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path >>>> and file may exist on my building machine, but not on the target. >>>> >>>> Fixes bug #8651. >>> >>> Have I to resend? >> >> Depends on the outcome of the discussion below. [snip] > I can assure the patch I submitted solves the problem. In mono > upstream, developers did a refactor of that part and the patch I > previously sent (for master) is simply wrong, cause the refactor > already solves the problem. Indeed I closed the issue on mono github. > > As you said previously, mono has a really slow release process, with > many months of delay, so I think we should stick with this latter > patch I sent. > > When the new release 4.3.X will be out, I will promptly bump to that > version and remove the unneeded patch. OK, so: - mono master is working; - backporting the upstream patch is a bit of work; - this simpler patch also works for us Therefore: Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> with the improved commit message mentioned above. Angelo, if you have a bit of time, please do resend with the improved commit message and my ack. As an aside, I searched for host-path references in the build result, and there still is one in /usr/lib/mono/gac/monodoc/1.0.0.0__0738eb9f132ed756/monodoc.dll.config Care to take a look at that? Regards, Arnout > > Sincerely, Angelo > >> >> Regards, >> Arnout >> >> [snip] >> >> -- >> Arnout Vandecappelle arnout at mind be >> Senior Embedded Software Architect +32-16-286500 >> Essensium/Mind http://www.mind.be >> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven >> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle >> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF > > >
Dear Arnout Vandecappelle, 2016-02-25 0:09 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: > On 02/24/16 21:46, Angelo Compagnucci wrote: >> Dear Arnout Vandecappelle, >> >> 2016-02-24 21:34 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: >>> On 02/23/16 23:29, Angelo Compagnucci wrote: >>>> Dear Arnout Vandecappelle, >>>> >>>> 2016-02-23 23:19 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>: >>>>> On 02/23/16 22:50, Angelo Compagnucci wrote: >>>>>> * This patch solves installation problems with monoposixhelper >>>>> >>>>> This description should be better, e.g. taking part of the bug description. >>>>> >>>>> libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path >>>>> and file may exist on my building machine, but not on the target. >>>>> >>>>> Fixes bug #8651. >>>> >>>> Have I to resend? >>> >>> Depends on the outcome of the discussion below. > [snip] >> I can assure the patch I submitted solves the problem. In mono >> upstream, developers did a refactor of that part and the patch I >> previously sent (for master) is simply wrong, cause the refactor >> already solves the problem. Indeed I closed the issue on mono github. >> >> As you said previously, mono has a really slow release process, with >> many months of delay, so I think we should stick with this latter >> patch I sent. >> >> When the new release 4.3.X will be out, I will promptly bump to that >> version and remove the unneeded patch. > > OK, so: > - mono master is working; > - backporting the upstream patch is a bit of work; > - this simpler patch also works for us > > Therefore: > > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > with the improved commit message mentioned above. Angelo, if you have a bit of > time, please do resend with the improved commit message and my ack. I will do as soon as possibile. A very big and sincere thank you for the great review. > As an aside, I searched for host-path references in the build result, and there > still is one in > /usr/lib/mono/gac/monodoc/1.0.0.0__0738eb9f132ed756/monodoc.dll.config > Care to take a look at that? Sure! Sincerely, Angelo > > Regards, > Arnout > >> >> Sincerely, Angelo >> >>> >>> Regards, >>> Arnout >>> >>> [snip] >>> >>> -- >>> Arnout Vandecappelle arnout at mind be >>> Senior Embedded Software Architect +32-16-286500 >>> Essensium/Mind http://www.mind.be >>> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven >>> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle >>> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF >> >> >> > > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
diff --git a/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch b/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch new file mode 100644 index 0000000..6ebb802 --- /dev/null +++ b/package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch @@ -0,0 +1,28 @@ +From 76aa4fb62a433e61dc35eefcc3077f0463182d2f Mon Sep 17 00:00:00 2001 +From: Angelo Compagnucci <angelo.compagnucci@gmail.com> +Date: Tue, 23 Feb 2016 22:43:39 +0100 +Subject: [PATCH] config.in: fixing wrong MonoPosixHelper location + +This patch remove a wrong prefix for libMonoPosixHelper + +Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> +--- + data/config.in | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/data/config.in b/data/config.in +index b760176..41495b9 100644 +--- a/data/config.in ++++ b/data/config.in +@@ -10,7 +10,7 @@ + <dllmap dll="i:odbc32.dll" target="libiodbc.dylib" os="osx"/> + <dllmap dll="oci" target="libclntsh@libsuffix@" os="!windows"/> + <dllmap dll="db2cli" target="libdb2_36@libsuffix@" os="!windows"/> +- <dllmap dll="MonoPosixHelper" target="@prefix@/@reloc_libdir@/libMonoPosixHelper@libsuffix@" os="!windows" /> ++ <dllmap dll="MonoPosixHelper" target="libMonoPosixHelper@libsuffix@" os="!windows" /> + <dllmap dll="i:msvcrt" target="@LIBC@" os="!windows"/> + <dllmap dll="i:msvcrt.dll" target="@LIBC@" os="!windows"/> + <dllmap dll="sqlite" target="@SQLITE@" os="!windows"/> +-- +1.9.1 +
* This patch solves installation problems with monoposixhelper * Fixes https://bugs.busybox.net/show_bug.cgi?id=8651 Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> --- Changelog: v2 -> v3: The patch was based on mono master and not on mono 4.2.2.30. This patch is now based on mono 4.2.2.30. This patch was tested on br_next. v1 -> v2: * Added SoB and description to patch ....in-fixing-wrong-MonoPosixHelper-location.patch | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 package/mono/0007-config.in-fixing-wrong-MonoPosixHelper-location.patch