diff mbox

i2c: tegra: don't open code of_device_get_match_data()

Message ID 1456063089-3403-1-git-send-email-wsa@the-dreams.de
State Accepted, archived
Headers show

Commit Message

Wolfram Sang Feb. 21, 2016, 1:57 p.m. UTC 
From: Wolfram Sang <wolfram@the-dreams.de>

This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.

Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
---

Compile tested only; HW test would be much appreciated!

 drivers/i2c/busses/i2c-tegra.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Laxman Dewangan Feb. 22, 2016, 9:18 a.m. UTC | #1 
On Sunday 21 February 2016 07:27 PM, Wolfram Sang wrote:
> From: Wolfram Sang <wolfram@the-dreams.de>
>
> This change will also make Coverity happy by avoiding a theoretical NULL
> pointer dereference; yet another reason is to use the above helper function
> to tighten the code and make it more readable.
>
> Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
> ---
>
> Compile tested only; HW test would be much appreciated!
>


Tested on Jetson-TX1.

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Tested-by: Laxman Dewangan <ldewangan@nvidia.com>


There is some more cleanups needed on this driver i.e. do not support 
non-DT, move the of_table to down etc. I like to post follow up post 
after this is applied.

Thanks,
Laxman

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfram Sang Feb. 24, 2016, 10:25 a.m. UTC | #2 
On Sun, Feb 21, 2016 at 02:57:42PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wolfram@the-dreams.de>
> 
> This change will also make Coverity happy by avoiding a theoretical NULL
> pointer dereference; yet another reason is to use the above helper function
> to tighten the code and make it more readable.
> 
> Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>

Applied to for-next, thanks!
Wolfram Sang Feb. 24, 2016, 10:26 a.m. UTC | #3 
> >This change will also make Coverity happy by avoiding a theoretical NULL
> >pointer dereference; yet another reason is to use the above helper function
> >to tighten the code and make it more readable.
> >
> >Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>
> >---
> >
> >Compile tested only; HW test would be much appreciated!
> 
> Tested on Jetson-TX1.

Thanks!

> There is some more cleanups needed on this driver i.e. do not support
> non-DT, move the of_table to down etc. I like to post follow up post after
> this is applied.

Please do. This is applied now, I'll push out later today.
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a0522fcc4ff875..929185a7296c0e 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -805,9 +805,7 @@  static int tegra_i2c_probe(struct platform_device *pdev)
 	i2c_dev->hw = &tegra20_i2c_hw;
 
 	if (pdev->dev.of_node) {
-		const struct of_device_id *match;
-		match = of_match_device(tegra_i2c_of_match, &pdev->dev);
-		i2c_dev->hw = match->data;
+		i2c_dev->hw = of_device_get_match_data(&pdev->dev);
 		i2c_dev->is_dvc = of_device_is_compatible(pdev->dev.of_node,
 						"nvidia,tegra20-i2c-dvc");
 	} else if (pdev->id == 3) {