| Message ID | 1456244344-12726-1-git-send-email-alexandre.belloni@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | ca57e0ba650c9a9596242009393f9501e157dd2e |
| Headers | show |
>>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@free-electrons.com> writes: > The recent changes in Config.in.arm regarding the VFP selection broke the > atmel_sama5d* defconfigs. Ensure EABIhf is selected as all the sama5 have a > vfp. They are not really broken in the sense that they don't build or boot, they are just less optimal, right? > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > configs/atmel_sama5d3_xplained_defconfig | 3 +-- > configs/atmel_sama5d3xek_defconfig | 3 +-- > configs/atmel_sama5d4_xplained_defconfig | 3 +-- We also have a atmel_sama5d3_xplained_mmc_defconfig that you forgot. Committed with that fixed, thanks. It seems like we need to fixup the other defconfigs using EABIHF as well :/ In hindsight, maybe BR2_ARM_ENABLE_VFP should have defaulted to 'y' instead.
On 23/02/2016 at 21:46:42 +0100, Peter Korsgaard wrote : > >>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@free-electrons.com> writes: > > > The recent changes in Config.in.arm regarding the VFP selection broke the > > atmel_sama5d* defconfigs. Ensure EABIhf is selected as all the sama5 have a > > vfp. > > They are not really broken in the sense that they don't build or boot, > they are just less optimal, right? > Indeed. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > configs/atmel_sama5d3_xplained_defconfig | 3 +-- > > configs/atmel_sama5d3xek_defconfig | 3 +-- > > configs/atmel_sama5d4_xplained_defconfig | 3 +-- > > We also have a atmel_sama5d3_xplained_mmc_defconfig that you > forgot. Committed with that fixed, thanks. > I changed it and I forgot to amend my commit, thanks for fixing that. > It seems like we need to fixup the other defconfigs using EABIHF as well > :/ In hindsight, maybe BR2_ARM_ENABLE_VFP should have defaulted to 'y' > instead. > Off list, I was suggesting to Thomas add BR2_ARM_ENABLE_VFP = y to all defconfigs with a BR2_ARM_FPU_VFP* but it only catches four more defconfigs. However, there are a lot more, like beaglebone, the allwiner based boards, most of the freescale ones, etc...
>>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@free-electrons.com> writes: Hi, >> We also have a atmel_sama5d3_xplained_mmc_defconfig that you >> forgot. Committed with that fixed, thanks. > I changed it and I forgot to amend my commit, thanks for fixing that. You're welcome. >> It seems like we need to fixup the other defconfigs using EABIHF as well >> :/ In hindsight, maybe BR2_ARM_ENABLE_VFP should have defaulted to 'y' >> instead. >> > Off list, I was suggesting to Thomas add BR2_ARM_ENABLE_VFP = y to all > defconfigs with a BR2_ARM_FPU_VFP* but it only catches four more > defconfigs. However, there are a lot more, like beaglebone, the > allwiner based boards, most of the freescale ones, etc... This is only a problem for CPU cores where the VFP is optional like arm926/A5/A9, and I've fixed up our A9 configs now so I believe it is ok.
diff --git a/configs/atmel_sama5d3_xplained_defconfig b/configs/atmel_sama5d3_xplained_defconfig index 74f613c55894..665a3d7cb33f 100644 --- a/configs/atmel_sama5d3_xplained_defconfig +++ b/configs/atmel_sama5d3_xplained_defconfig @@ -1,7 +1,6 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y diff --git a/configs/atmel_sama5d3xek_defconfig b/configs/atmel_sama5d3xek_defconfig index 64eabe81dee5..193fa1365108 100644 --- a/configs/atmel_sama5d3xek_defconfig +++ b/configs/atmel_sama5d3xek_defconfig @@ -1,7 +1,6 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y diff --git a/configs/atmel_sama5d4_xplained_defconfig b/configs/atmel_sama5d4_xplained_defconfig index 67e2eb2fbb89..0991f86fa682 100644 --- a/configs/atmel_sama5d4_xplained_defconfig +++ b/configs/atmel_sama5d4_xplained_defconfig @@ -1,8 +1,7 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y BR2_ARM_ENABLE_NEON=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y diff --git a/configs/atmel_sama5d4ek_defconfig b/configs/atmel_sama5d4ek_defconfig index 73d0a185190c..92b08400124f 100644 --- a/configs/atmel_sama5d4ek_defconfig +++ b/configs/atmel_sama5d4ek_defconfig @@ -1,8 +1,7 @@ BR2_arm=y BR2_cortex_a5=y -BR2_ARM_EABIHF=y BR2_ARM_ENABLE_NEON=y -BR2_ARM_FPU_VFPV4D16=y +BR2_ARM_ENABLE_VFP=y BR2_ARM_INSTRUCTIONS_THUMB2=y # Linux headers same as kernel, a 3.18 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
The recent changes in Config.in.arm regarding the VFP selection broke the atmel_sama5d* defconfigs. Ensure EABIhf is selected as all the sama5 have a vfp. Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- configs/atmel_sama5d3_xplained_defconfig | 3 +-- configs/atmel_sama5d3xek_defconfig | 3 +-- configs/atmel_sama5d4_xplained_defconfig | 3 +-- configs/atmel_sama5d4ek_defconfig | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-)