diff mbox

Remove unused variables

Message ID mvmr3h4ioxu.fsf@hawking.suse.de
State New
Headers show

Commit Message

Andreas Schwab Jan. 26, 2016, 11:02 a.m. UTC 
These are flagged by -Wunused-const-variable.

	* sysdeps/ieee754/ldbl-128ibm/s_erfl.c (half): Remove.
	* sysdeps/ieee754/ldbl-128ibm/s_log1pl.c (maxlog, big): Remove.
	* sysdeps/powerpc/fpu/s_cosf.c (one): Remove.
	* sysdeps/powerpc/fpu/e_hypotf.c (two30): Remove.
---
 sysdeps/ieee754/ldbl-128ibm/s_erfl.c   | 1 -
 sysdeps/ieee754/ldbl-128ibm/s_log1pl.c | 2 --
 sysdeps/powerpc/fpu/e_hypotf.c         | 2 --
 sysdeps/powerpc/fpu/s_cosf.c           | 1 -
 4 files changed, 6 deletions(-)

Comments

Joseph Myers Jan. 26, 2016, 5:38 p.m. UTC | #1 
On Tue, 26 Jan 2016, Andreas Schwab wrote:

> These are flagged by -Wunused-const-variable.
> 
> 	* sysdeps/ieee754/ldbl-128ibm/s_erfl.c (half): Remove.
> 	* sysdeps/ieee754/ldbl-128ibm/s_log1pl.c (maxlog, big): Remove.
> 	* sysdeps/powerpc/fpu/s_cosf.c (one): Remove.
> 	* sysdeps/powerpc/fpu/e_hypotf.c (two30): Remove.

OK.
cseo Jan. 26, 2016, 5:57 p.m. UTC | #2 
On 1/26/16 9:02 AM, Andreas Schwab wrote:
> These are flagged by -Wunused-const-variable.
>
> 	* sysdeps/ieee754/ldbl-128ibm/s_erfl.c (half): Remove.
> 	* sysdeps/ieee754/ldbl-128ibm/s_log1pl.c (maxlog, big): Remove.
> 	* sysdeps/powerpc/fpu/s_cosf.c (one): Remove.
> 	* sysdeps/powerpc/fpu/e_hypotf.c (two30): Remove.

LGTM. I was just checking if we should remove the variables or suppress 
the warning when you submitted this :)
diff mbox

Patch

diff --git a/sysdeps/ieee754/ldbl-128ibm/s_erfl.c b/sysdeps/ieee754/ldbl-128ibm/s_erfl.c
index 82d889d..7b761b0 100644
--- a/sysdeps/ieee754/ldbl-128ibm/s_erfl.c
+++ b/sysdeps/ieee754/ldbl-128ibm/s_erfl.c
@@ -147,7 +147,6 @@  deval (long double x, const long double *p, int n)
 
 static const long double
 tiny = 1e-300L,
-  half = 0.5L,
   one = 1.0L,
   two = 2.0L,
   /* 2/sqrt(pi) - 1 */
diff --git a/sysdeps/ieee754/ldbl-128ibm/s_log1pl.c b/sysdeps/ieee754/ldbl-128ibm/s_log1pl.c
index ad9a1fe..743693b 100644
--- a/sysdeps/ieee754/ldbl-128ibm/s_log1pl.c
+++ b/sysdeps/ieee754/ldbl-128ibm/s_log1pl.c
@@ -117,8 +117,6 @@  static const long double C2 = 1.428606820309417232121458176568075500134E-6L;
 
 static const long double sqrth = 0.7071067811865475244008443621048490392848L;
 /* ln (2^16384 * (1 - 2^-113)) */
-static const long double maxlog = 1.1356523406294143949491931077970764891253E4L;
-static const long double big = 2e300L;
 static const long double zero = 0.0L;
 
 
diff --git a/sysdeps/powerpc/fpu/e_hypotf.c b/sysdeps/powerpc/fpu/e_hypotf.c
index c27df25..4836082 100644
--- a/sysdeps/powerpc/fpu/e_hypotf.c
+++ b/sysdeps/powerpc/fpu/e_hypotf.c
@@ -21,8 +21,6 @@ 
 #include <math_private.h>
 #include <stdint.h>
 
-static const float two30  = 1.0737418e09;
-
 /* __ieee754_hypotf(x,y)
 
    This a FP only version without any FP->INT conversion.
diff --git a/sysdeps/powerpc/fpu/s_cosf.c b/sysdeps/powerpc/fpu/s_cosf.c
index 2d1ec1b..eaeaebc 100644
--- a/sysdeps/powerpc/fpu/s_cosf.c
+++ b/sysdeps/powerpc/fpu/s_cosf.c
@@ -21,7 +21,6 @@ 
 #include <math.h>
 #include <math_private.h>
 
-static const float one  = 1.0;
 static const float pio4 = 7.8539801e-1;
 
 float