diff mbox

[rs6000] Fix PR63354

Message ID 1453688272.18740.2.camel@gnopaine
State New
Headers show

Commit Message

Bill Schmidt Jan. 25, 2016, 2:17 a.m. UTC 
On Sun, 2016-01-24 at 02:18 +0100, Jan-Benedict Glaw wrote:
> On Thu, 2016-01-21 23:42:40 -0600, Bill Schmidt <wschmidt@linux.vnet.ibm.com> wrote:
> > On Thu, 2016-01-21 at 21:21 -0600, Bill Schmidt wrote:
> > > The testcase will need a slight adjustment, as currently it fails on
> > > powerpc64 with -m32 testing.  Working on a fix.
> > 
> > This patch adjusts the gcc.target/powerpc/pr63354 test to require 64-bit
> > code generation, and also restricts the test to Linux targets, as this
> > is necessary for using -mprofile-kernel.  Tested on
> > powerpc64-unknown-linux-gnu configured with --with-cpu=power7 and
> > testing with -m32; the test is now correctly skipped there.  Is this
> > okay for trunk?
> 
> Building for --target=powerpc-xilinx-eabi, I see this on my build
> robot (see at the bottom of the page, the make.out artifact of build
> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=483851):
> 
> g++ -fno-PIE -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include  -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace   -o rs6000.o -MT rs6000.o -MMD -MP -MF ./.deps/rs6000.TPo ../../../gcc/gcc/config/rs6000/rs6000.c
> ../../../gcc/gcc/config/rs6000/rs6000.c:26243:1: error: ‘bool rs6000_keep_leaf_when_profiled()’ defined but not used [-Werror=unused-function]
>  rs6000_keep_leaf_when_profiled ()
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> cc1plus: all warnings being treated as errors
> Makefile:2121: recipe for target 'rs6000.o' failed
> make[2]: *** [rs6000.o] Error 1
> make[2]: Leaving directory '/home/jbglaw/build-configlist_mk/powerpc-xilinx-eabi/build-gcc/mk/powerpc-xilinx-eabi/gcc'
> Makefile:4123: recipe for target 'all-gcc' failed
> make[1]: *** [all-gcc] Error 2
> make[1]: Leaving directory '/home/jbglaw/build-configlist_mk/powerpc-xilinx-eabi/build-gcc/mk/powerpc-xilinx-eabi'
> 
> 
> MfG, JBG
> 

Hi Jan, thanks for the report!  Patch below that should fix the problem.
Bootstrapped and tested on powerpc64le-unknown-linux-gnu, no
regressions.  David, is this ok for trunk?

Thanks,
Bill


2016-01-24  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	* config/rs6000/rs6000.c (rs6000_keep_leaf_when_profiled):  Add
	decl with __attribute__ ((unused)) annotation.

Comments

David Edelsohn Jan. 25, 2016, 1:54 p.m. UTC | #1 
On Sun, Jan 24, 2016 at 9:17 PM, Bill Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:

> Hi Jan, thanks for the report!  Patch below that should fix the problem.
> Bootstrapped and tested on powerpc64le-unknown-linux-gnu, no
> regressions.  David, is this ok for trunk?
>
> Thanks,
> Bill
>
>
> 2016-01-24  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
>
>         * config/rs6000/rs6000.c (rs6000_keep_leaf_when_profiled):  Add
>         decl with __attribute__ ((unused)) annotation.

Okay.

Thanks, David
Bill Schmidt Jan. 25, 2016, 2:07 p.m. UTC | #2 
Thanks, committed as r232793.

Bill

On Mon, 2016-01-25 at 08:54 -0500, David Edelsohn wrote:
> On Sun, Jan 24, 2016 at 9:17 PM, Bill Schmidt
> <wschmidt@linux.vnet.ibm.com> wrote:
> 
> > Hi Jan, thanks for the report!  Patch below that should fix the problem.
> > Bootstrapped and tested on powerpc64le-unknown-linux-gnu, no
> > regressions.  David, is this ok for trunk?
> >
> > Thanks,
> > Bill
> >
> >
> > 2016-01-24  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
> >
> >         * config/rs6000/rs6000.c (rs6000_keep_leaf_when_profiled):  Add
> >         decl with __attribute__ ((unused)) annotation.
> 
> Okay.
> 
> Thanks, David
>
diff mbox

Patch

Index: gcc/config/rs6000/rs6000.c
===================================================================
--- gcc/config/rs6000/rs6000.c	(revision 232783)
+++ gcc/config/rs6000/rs6000.c	(working copy)
@@ -1311,6 +1311,7 @@  static bool rs6000_secondary_reload_move (enum rs6
 					  secondary_reload_info *,
 					  bool);
 rtl_opt_pass *make_pass_analyze_swaps (gcc::context*);
+static bool rs6000_keep_leaf_when_profiled () __attribute__ ((unused));
 
 /* Hash table stuff for keeping track of TOC entries.  */