diff mbox

[1/1] readline: fix stripping on target

Message ID 1452185782-7505-1-git-send-email-casantos@datacom.ind.br
State Accepted
Commit af8501cf963d2b23f8c092615a4c047da92accfd
Headers show

Commit Message

Carlos Santos Jan. 7, 2016, 4:56 p.m. UTC
Libraries got installed read only, so strip failed.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
---
 package/readline/readline.mk | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Gustavo Zacarias Jan. 8, 2016, 5:54 p.m. UTC | #1
On 07/01/16 13:56, Carlos Santos wrote:

> Libraries got installed read only, so strip failed.
>
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>

Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Regards.
Peter Korsgaard Jan. 8, 2016, 6:16 p.m. UTC | #2
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes:

 > Libraries got installed read only, so strip failed.
 > Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
 > ---
 >  package/readline/readline.mk | 9 +++++++++
 >  1 file changed, 9 insertions(+)

 > diff --git a/package/readline/readline.mk b/package/readline/readline.mk
 > index 3d31696..58cd948 100644
 > --- a/package/readline/readline.mk
 > +++ b/package/readline/readline.mk
 > @@ -24,5 +24,14 @@ define READLINE_INSTALL_INPUTRC
 >  endef
 >  READLINE_POST_INSTALL_TARGET_HOOKS += READLINE_INSTALL_INPUTRC
 
 > +ifneq ($(BR2_STATIC_LIBS),y)
 > +# libraries get installed read only, so strip fails
 > +define READLINE_INSTALL_FIXUPS_SHARED
 > +	for i in $(addprefix $(TARGET_DIR)/usr/lib/,libhistory.so.* libreadline.so.*); \
 > +	do chmod +w $$i; done
 > +endef

Committed after simplifying it to just be:

chmod +w $(addprefix $(TARGET_DIR)/usr/lib/,libhistory.so.* libreadline.so.*)

Thanks.
diff mbox

Patch

diff --git a/package/readline/readline.mk b/package/readline/readline.mk
index 3d31696..58cd948 100644
--- a/package/readline/readline.mk
+++ b/package/readline/readline.mk
@@ -24,5 +24,14 @@  define READLINE_INSTALL_INPUTRC
 endef
 READLINE_POST_INSTALL_TARGET_HOOKS += READLINE_INSTALL_INPUTRC
 
+ifneq ($(BR2_STATIC_LIBS),y)
+# libraries get installed read only, so strip fails
+define READLINE_INSTALL_FIXUPS_SHARED
+	for i in $(addprefix $(TARGET_DIR)/usr/lib/,libhistory.so.* libreadline.so.*); \
+	do chmod +w $$i; done
+endef
+READLINE_POST_INSTALL_TARGET_HOOKS += READLINE_INSTALL_FIXUPS_SHARED
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))