Message ID | B5E67142681B53468FAF6B7C3135656244359647@HHMAIL01.hh.imgtec.org |
---|---|
State | New |
Headers | show |
Robert Suchanek <Robert.Suchanek@imgtec.com> writes: > gcc/ > * config/mips/mips-ftypes.def: Sort to lexicographical order. The patch is fine. I don't know what we can/should commit at this stage. Catherine: Any idea what is acceptable? I'd think this kind of small change to be OK and make it easier to maintain MSA out of tree given I doubt it can be committed now. Thanks, Matthew
> -----Original Message----- > From: Matthew Fortune [mailto:Matthew.Fortune@imgtec.com] > Sent: Tuesday, January 05, 2016 11:45 AM > To: Robert Suchanek; Moore, Catherine > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH][MIPS] Reorder function types > > Robert Suchanek <Robert.Suchanek@imgtec.com> writes: > > gcc/ > > * config/mips/mips-ftypes.def: Sort to lexicographical order. > > The patch is fine. I don't know what we can/should commit at this stage. > Catherine: Any idea what is acceptable? I'd think this kind of small change to > be OK and make it easier to maintain MSA out of tree given I doubt it can be > committed now. > This is fine to commit now.
Hi Catherine, > > > > Robert Suchanek <Robert.Suchanek@imgtec.com> writes: > > > gcc/ > > > * config/mips/mips-ftypes.def: Sort to lexicographical order. > > > > The patch is fine. I don't know what we can/should commit at this stage. > > Catherine: Any idea what is acceptable? I'd think this kind of small change to > > be OK and make it easier to maintain MSA out of tree given I doubt it can be > > committed now. > > > This is fine to commit now. Committed as r232113. Regards, Robert
diff --git a/gcc/config/mips/mips-ftypes.def b/gcc/config/mips/mips-ftypes.def index d56accc..e1656ee 100644 --- a/gcc/config/mips/mips-ftypes.def +++ b/gcc/config/mips/mips-ftypes.def @@ -42,6 +42,7 @@ DEF_MIPS_FTYPE (3, (DI, DI, SI, SI)) DEF_MIPS_FTYPE (3, (DI, DI, USI, USI)) DEF_MIPS_FTYPE (3, (DI, DI, V2HI, V2HI)) DEF_MIPS_FTYPE (3, (DI, DI, V4QI, V4QI)) +DEF_MIPS_FTYPE (2, (DI, POINTER, SI)) DEF_MIPS_FTYPE (2, (DI, SI, SI)) DEF_MIPS_FTYPE (2, (DI, USI, USI)) @@ -50,9 +51,12 @@ DEF_MIPS_FTYPE (2, (INT, SF, SF)) DEF_MIPS_FTYPE (2, (INT, V2SF, V2SF)) DEF_MIPS_FTYPE (4, (INT, V2SF, V2SF, V2SF, V2SF)) +DEF_MIPS_FTYPE (1, (SF, SF)) +DEF_MIPS_FTYPE (2, (SF, SF, SF)) +DEF_MIPS_FTYPE (1, (SF, V2SF)) + DEF_MIPS_FTYPE (2, (SI, DI, SI)) DEF_MIPS_FTYPE (2, (SI, POINTER, SI)) -DEF_MIPS_FTYPE (2, (DI, POINTER, SI)) DEF_MIPS_FTYPE (1, (SI, SI)) DEF_MIPS_FTYPE (2, (SI, SI, SI)) DEF_MIPS_FTYPE (3, (SI, SI, SI, SI)) @@ -62,10 +66,6 @@ DEF_MIPS_FTYPE (1, (SI, V4QI)) DEF_MIPS_FTYPE (2, (SI, V4QI, V4QI)) DEF_MIPS_FTYPE (1, (SI, VOID)) -DEF_MIPS_FTYPE (1, (SF, SF)) -DEF_MIPS_FTYPE (2, (SF, SF, SF)) -DEF_MIPS_FTYPE (1, (SF, V2SF)) - DEF_MIPS_FTYPE (2, (UDI, UDI, UDI)) DEF_MIPS_FTYPE (2, (UDI, UV2SI, UV2SI)) @@ -76,9 +76,9 @@ DEF_MIPS_FTYPE (2, (UV2SI, UV2SI, UV2SI)) DEF_MIPS_FTYPE (2, (UV4HI, UV4HI, UQI)) DEF_MIPS_FTYPE (2, (UV4HI, UV4HI, USI)) +DEF_MIPS_FTYPE (2, (UV4HI, UV4HI, UV4HI)) DEF_MIPS_FTYPE (3, (UV4HI, UV4HI, UV4HI, UQI)) DEF_MIPS_FTYPE (3, (UV4HI, UV4HI, UV4HI, USI)) -DEF_MIPS_FTYPE (2, (UV4HI, UV4HI, UV4HI)) DEF_MIPS_FTYPE (1, (UV4HI, UV8QI)) DEF_MIPS_FTYPE (2, (UV4HI, UV8QI, UV8QI))