Message ID | C2D7FE5348E1B147BCA15975FBA23075F44D2EEF@IN01WEMBXA.internal.synopsys.com |
---|---|
State | Not Applicable, archived |
Delegated to: | Vineet Gupta |
Headers | show |
Hi Vineet, the original version went through the buildbot, which succeeded. It seems like the official buildbot does not support arc, and might benefit from helping to set up an arc environment. However in the meantime Guenther send me output from his buildbot and I sent a fix for arc.
On Tuesday 24 November 2015 01:20 PM, hch@lst.de wrote: > Hi Vineet, > > the original version went through the buildbot, which succeeded. It seems > like the official buildbot does not support arc, and might benefit from > helping to set up an arc environment. I have in the past asked kisskb service folks - but haven't heard back from them. Stephan, Michael could you please add ARC toolchain to kisskb build service. I can buy you guys a beer (or some other beverage of choice) next time we meet :-) > However in the meantime Guenther > send me output from his buildbot and I sent a fix for arc. Ok - perhaps Guenter didn't CC me and hence I didn't see you fix. Thx for doing this series BTW, I was meaning to do this myself as some customers asked for using dma_attr_t etc for their upcoming platform. -Vineet
On Tue, 2015-11-24 at 09:46 +0000, Vineet Gupta wrote: > On Tuesday 24 November 2015 01:20 PM, hch@lst.de wrote: > > Hi Vineet, > > > > the original version went through the buildbot, which succeeded. It seems > > like the official buildbot does not support arc, and might benefit from > > helping to set up an arc environment. > > I have in the past asked kisskb service folks - but haven't heard back from them. > Stephan, Michael could you please add ARC toolchain to kisskb build service. I can > buy you guys a beer (or some other beverage of choice) next time we meet :-) Sure, where do I get a toolchain? Can I just build upstream binutils + GCC? chers
Hi Michael, On Tuesday 24 November 2015 04:31 PM, Michael Ellerman wrote: > On Tue, 2015-11-24 at 09:46 +0000, Vineet Gupta wrote: >> > On Tuesday 24 November 2015 01:20 PM, hch@lst.de wrote: >>> > > Hi Vineet, >>> > > >>> > > the original version went through the buildbot, which succeeded. It seems >>> > > like the official buildbot does not support arc, and might benefit from >>> > > helping to set up an arc environment. >> > >> > I have in the past asked kisskb service folks - but haven't heard back from them. >> > Stephan, Michael could you please add ARC toolchain to kisskb build service. I can >> > buy you guys a beer (or some other beverage of choice) next time we meet :-) > Sure, where do I get a toolchain? Can I just build upstream binutils + GCC? > > chers We are in the process of revamping upstream support for GNU tools (they were added many years ago, bit-rotted and now are being redone again). The current tools are hoisted on github. https://github.com/foss-for-synopsys-dwc-arc-processors/ You could use upstream buildroot which automatically picks up relevant tools branches from our github repos. Please note that ARC cores are based off two ISA: ARCompact and recently announced ARCv2. Thus it would be awesome if we could build following kernel configs on regular basis: - axs101_defconfig - axs103_smp_defconfig This however needs 2 toolchain installs as we don't have multilibed tools which support both ISA. You can do following to generate the tools (this first pass builds the kernel as well which can be disabled if u so wish). $ wget http://buildroot.uclibc.org/downloads/buildroot-2015.08.1.tar.gz $ tar -xvf buildroot-2015.08.1.tar.gz $ cd buildroot-2015.08.1; mkdir arcv2 arcomp $ make O=arcv2 snps_axs103_defconfig ; cd arcv2; make ; cd .. # for ARCv2 tools $ make O=arcomp snps_axs101_defconfig ; cd arcomp; make # for ARCompact tools There's another way to build them by hand - with finer grainer control of specific tools branches, target flags and so forth. Let me know if you prefer that and I can point you to same (they in toolchain repo on github) Many thx for looking into this. Please let me know if you run into any issues with above. -Vineet
On Tue, 2015-11-24 at 17:09 +0530, Vineet Gupta wrote: > Hi Michael, > On Tuesday 24 November 2015 04:31 PM, Michael Ellerman wrote: > > On Tue, 2015-11-24 at 09:46 +0000, Vineet Gupta wrote: > > > > On Tuesday 24 November 2015 01:20 PM, hch@lst.de wrote: > > > > > > Hi Vineet, > > > > > > > > > > > > the original version went through the buildbot, which succeeded. It seems > > > > > > like the official buildbot does not support arc, and might benefit from > > > > > > helping to set up an arc environment. > > > > > > > > I have in the past asked kisskb service folks - but haven't heard back from them. > > > > Stephan, Michael could you please add ARC toolchain to kisskb build service. I can > > > > buy you guys a beer (or some other beverage of choice) next time we meet :-) > > Sure, where do I get a toolchain? Can I just build upstream binutils + GCC? > > > We are in the process of revamping upstream support for GNU tools (they were added > many years ago, bit-rotted and now are being redone again). > > The current tools are hoisted on github. > https://github.com/foss-for-synopsys-dwc-arc-processors/ > > You could use upstream buildroot which automatically picks up relevant tools > branches from our github repos. > > Please note that ARC cores are based off two ISA: ARCompact and recently announced > ARCv2. Thus it would be awesome if we could build following kernel configs on > regular basis: > - axs101_defconfig > - axs103_smp_defconfig > > This however needs 2 toolchain installs as we don't have multilibed tools which > support both ISA. > > You can do following to generate the tools (this first pass builds the kernel as > well which can be disabled if u so wish). > > $ wget http://buildroot.uclibc.org/downloads/buildroot-2015.08.1.tar.gz > $ tar -xvf buildroot-2015.08.1.tar.gz > $ cd buildroot-2015.08.1; mkdir arcv2 arcomp > > $ make O=arcv2 snps_axs103_defconfig ; cd arcv2; make ; cd .. # for ARCv2 tools > $ make O=arcomp snps_axs101_defconfig ; cd arcomp; make # for ARCompact tools OK. In general I'm not inclined to support custom toolchains, simply because of the extra work required. But seeing as you asked nicely and gave me instructions I'll try and build it and see how I go :) cheers
On Tuesday 24 November 2015 01:20 PM, hch@lst.de wrote: > Hi Vineet, > > the original version went through the buildbot, which succeeded. It seems > like the official buildbot does not support arc, and might benefit from > helping to set up an arc environment. However in the meantime Guenther > send me output from his buildbot and I sent a fix for arc. > Hi Andrew, Christoph The dma mapping conversion build error fixlet (below) exists as a separate patch which will break bisectability. Will it be possible to squash it into the orig commit. Thx, -Vineet commit 7f33b4a409493b81c24741dbad6700aae99d8ed0 Author: Christoph Hellwig <hch@lst.de> Date: Fri Dec 11 15:59:33 2015 +1100 arc: dma mapping fixes Signed-off-by: Christoph Hellwig <hch@lst.de> Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
On Thu, 17 Dec 2015 10:58:55 +0530 Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > On Tuesday 24 November 2015 01:20 PM, hch@lst.de wrote: > > Hi Vineet, > > > > the original version went through the buildbot, which succeeded. It seems > > like the official buildbot does not support arc, and might benefit from > > helping to set up an arc environment. However in the meantime Guenther > > send me output from his buildbot and I sent a fix for arc. > > > > Hi Andrew, Christoph > > The dma mapping conversion build error fixlet (below) exists as a separate patch > which will break bisectability. Will it be possible to squash it into the orig commit. > That's the plan. In http://ozlabs.org/~akpm/mmots/series you'll see arc-convert-to-dma_map_ops.patch arc-convert-to-dma_map_ops-fix.patch I keep the base patch(es) and its fixes separate for various tacking/history/bookkeeping reasons and fold them all together just before sending things off to Linus.
From d924a26542660cd1ac68f8f86f8b646835ef5179 Mon Sep 17 00:00:00 2001 From: Vineet Gupta <vgupta@synopsys.com> Date: Tue, 24 Nov 2015 09:46:05 +0530 Subject: [PATCH] arc: fix wreakage of conversion to dma_map_ops Obviously the initial patch was not build tested. Reported-by: Anton Kolesov <akolesov@synopsys.com> Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- arch/arc/mm/dma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arc/mm/dma.c b/arch/arc/mm/dma.c index da289cb30ca5..695029f41a48 100644 --- a/arch/arc/mm/dma.c +++ b/arch/arc/mm/dma.c @@ -46,7 +46,7 @@ static void *arc_dma_alloc(struct device *dev, size_t size, * (vs. always going to memory - thus are faster) */ if ((is_isa_arcv2() && ioc_exists) || - dma_get_attr(DMA_ATTR_NON_CONSISTENT, attrs) + dma_get_attr(DMA_ATTR_NON_CONSISTENT, attrs)) return paddr; /* This is kernel Virtual address (0x7000_0000 based) */ @@ -74,7 +74,7 @@ static void arc_dma_free(struct device *dev, size_t size, void *vaddr, { if (!(is_isa_arcv2() && ioc_exists) || dma_get_attr(DMA_ATTR_NON_CONSISTENT, attrs)) - iounmap((void __force __iomem *)kvaddr); + iounmap((void __force __iomem *)vaddr); free_pages_exact((void *)dma_handle, size); } @@ -135,7 +135,7 @@ static void arc_dma_sync_single_for_device(struct device *dev, _dma_cache_sync(dma_handle, size, DMA_TO_DEVICE); } -static void arm_dma_sync_sg_for_cpu(struct device *dev, +static void arc_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sglist, int nelems, enum dma_data_direction dir) { @@ -171,7 +171,7 @@ struct dma_map_ops arc_dma_ops = { .sync_single_for_device = arc_dma_sync_single_for_device, .sync_single_for_cpu = arc_dma_sync_single_for_cpu, .sync_sg_for_cpu = arc_dma_sync_sg_for_cpu, - .sync_sg_for_dev = arc_dma_sync_sg_for_device, + .sync_sg_for_device = arc_dma_sync_sg_for_device, .dma_supported = arc_dma_supported, }; EXPORT_SYMBOL(arc_dma_ops); -- 1.9.1