diff mbox

[next,S23,03/13] i40e: Add mac_filter_element at the end of the list instead of HEAD

Message ID 1449705033-4968-4-git-send-email-joshua.a.hay@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show

Commit Message

Joshua Hay Dec. 9, 2015, 11:50 p.m. UTC
From: Kiran Patil <kiran.patil@intel.com>

Add MAC filter element to the end of the list in the given order,
just to be tidy, and just in case there are ever any ordering issues in
the future.

Signed-off-by: Kiran Patil <kiran.patil@intel.com>
Change-ID: Idc15276147593ea9393ac72c861f9c7905a791b4
---
Testing Hints: There is no straight targeted test for this issue.

 drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bowers, AndrewX Dec. 16, 2015, 6:37 p.m. UTC | #1
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Joshua Hay
> Sent: Wednesday, December 09, 2015 3:50 PM
> To: intel-wired-lan@lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S23 03/13] i40e: Add
> mac_filter_element at the end of the list instead of HEAD
> 
> From: Kiran Patil <kiran.patil@intel.com>
> 
> Add MAC filter element to the end of the list in the given order, just to be
> tidy, and just in case there are ever any ordering issues in the future.
> 
> Signed-off-by: Kiran Patil <kiran.patil@intel.com>
> Change-ID: Idc15276147593ea9393ac72c861f9c7905a791b4
> ---
> Testing Hints: There is no straight targeted test for this issue.
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Patch code changes correctly applied
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 4fd29e7..44bbfd8 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1365,7 +1365,7 @@  struct i40e_mac_filter *i40e_add_filter(struct i40e_vsi *vsi,
 		f->changed = true;
 
 		INIT_LIST_HEAD(&f->list);
-		list_add(&f->list, &vsi->mac_filter_list);
+		list_add_tail(&f->list, &vsi->mac_filter_list);
 	}
 
 	/* increment counter and add a new flag if needed */