| Message ID | 1449767098-8494-1-git-send-email-jk@ozlabs.org |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Dec 11, 2015 at 3:34 AM, Jeremy Kerr <jk@ozlabs.org> wrote: > We're not initialising 'size' in handle_prd_control_run_cmd. I had this ready to go too. > Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > external/opal-prd/opal-prd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c > index 115443c..a82000a 100644 > --- a/external/opal-prd/opal-prd.c > +++ b/external/opal-prd/opal-prd.c > @@ -1317,6 +1317,7 @@ static void handle_prd_control_run_cmd(struct control_msg *send_msg, > } > > s = (char *)recv_msg->data; > + size = 0; > for (i = 0; i < argc; i++) { > argv[i] = (char *)htobe64((uint64_t)&s[size]); > size += (strlen(&s[size]) + 1); > -- > 2.5.0 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
Jeremy Kerr <jk@ozlabs.org> writes: > We're not initialising 'size' in handle_prd_control_run_cmd. > > Signed-off-by: Jeremy Kerr <jk@ozlabs.org> > --- > external/opal-prd/opal-prd.c | 1 + > 1 file changed, 1 insertion(+) Thanks, merged to stable and master.
diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c index 115443c..a82000a 100644 --- a/external/opal-prd/opal-prd.c +++ b/external/opal-prd/opal-prd.c @@ -1317,6 +1317,7 @@ static void handle_prd_control_run_cmd(struct control_msg *send_msg, } s = (char *)recv_msg->data; + size = 0; for (i = 0; i < argc; i++) { argv[i] = (char *)htobe64((uint64_t)&s[size]); size += (strlen(&s[size]) + 1);
We're not initialising 'size' in handle_prd_control_run_cmd. Signed-off-by: Jeremy Kerr <jk@ozlabs.org> --- external/opal-prd/opal-prd.c | 1 + 1 file changed, 1 insertion(+)