| Message ID | 1449302218-54374-3-git-send-email-yankejian@huawei.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Saturday 05 December 2015 15:56:57 yankejian wrote: > #size-cells = <0>; > compatible = "hisilicon,hns-mdio"; > - reg = <0x0 0x803c0000 0x0 0x10000 > - 0x0 0x80000000 0x0 0x10000>; > + reg = <0x0 0x803c0000 0x0 0x10000>; > + subctrl_vbase = <&peri_c_subctrl>; > > soc0_phy0: ethernet-phy@0 { > reg = <0x0>; I don't see the subctrl_vbase property documented in the binding. Please modify the binding as well. Also, please use the normal naming conventions using '-' instead of '_' inside of property names. Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015/12/6 6:15, Arnd Bergmann wrote: > On Saturday 05 December 2015 15:56:57 yankejian wrote: >> #size-cells = <0>; >> compatible = "hisilicon,hns-mdio"; >> - reg = <0x0 0x803c0000 0x0 0x10000 >> - 0x0 0x80000000 0x0 0x10000>; >> + reg = <0x0 0x803c0000 0x0 0x10000>; >> + subctrl_vbase = <&peri_c_subctrl>; >> >> soc0_phy0: ethernet-phy@0 { >> reg = <0x0>; > I don't see the subctrl_vbase property documented in the binding. Please > modify the binding as well. > > Also, please use the normal naming conventions using '-' instead of '_' > inside of property names. > > Arnd > > . Hi, Arnd Thanks for your suggestions. i will fixes it later. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi index 4ff16d0..daaca63 100644 --- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi @@ -246,6 +246,10 @@ clock-frequency = <200000000>; }; + peri_c_subctrl: sub_ctrl_c@80000000 { + compatible = "hisilicon,peri-c-subctrl", "syscon"; + reg = < 0x0 0x80000000 0x0 0x10000>; + }; uart0: uart@80300000 { compatible = "snps,dw-apb-uart"; reg = <0x0 0x80300000 0x0 0x10000>; diff --git a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi index 606dd5a..4d4815e 100644 --- a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi @@ -10,8 +10,8 @@ soc0: soc@000000000 { #address-cells = <1>; #size-cells = <0>; compatible = "hisilicon,hns-mdio"; - reg = <0x0 0x803c0000 0x0 0x10000 - 0x0 0x80000000 0x0 0x10000>; + reg = <0x0 0x803c0000 0x0 0x10000>; + subctrl_vbase = <&peri_c_subctrl>; soc0_phy0: ethernet-phy@0 { reg = <0x0>;
when linux start up, we get the log below: "Hi-HNS_MDIO 803c0000.mdio: no syscon hisilicon,peri-c-subctrl mdio_bus mdio@803c0000: mdio sys ctl reg has not maped " the source code about the subctrl is dealled with syscon, but dts doesn't. it cause such fault. so this patch adds the syscon info on dts files to fixes it. Signed-off-by: yankejian <yankejian@huawei.com> --- arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++++ arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)