| Message ID | 1448530892-4893-2-git-send-email-yamamoto@midokura.com |
|---|---|
| State | Rejected |
| Headers | show |
On Thu, Nov 26, 2015 at 06:41:31PM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> Reviewed-by: Simon Horman <simon.horman@netronome.com>
On Thu, Nov 26, 2015 at 06:41:31PM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> > --- > tests/ovn.at | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index de0a830..a4dbf96 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -566,7 +566,7 @@ ovn-sbctl dump-flows -- list multicast_group > # more) list the VIFs on which the packet should be received. INPORT and the > # OUTPORTs are specified as lport numbers, e.g. 11 for vif11. > trim_zeros() { > - sed 's/\(00\)\{1,\}$//' > + sed 's/\(00\)\(00\)*$//' > } I'm pretty sure this is a standard POSIX basic regular expression, see 9.3.6 item 5 at http://pubs.opengroup.org/onlinepubs/9699919799/. BSD doesn't support it?
hi, On Sat, Nov 28, 2015 at 3:20 AM, Ben Pfaff <blp@ovn.org> wrote: > On Thu, Nov 26, 2015 at 06:41:31PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> >> --- >> tests/ovn.at | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tests/ovn.at b/tests/ovn.at >> index de0a830..a4dbf96 100644 >> --- a/tests/ovn.at >> +++ b/tests/ovn.at >> @@ -566,7 +566,7 @@ ovn-sbctl dump-flows -- list multicast_group >> # more) list the VIFs on which the packet should be received. INPORT and the >> # OUTPORTs are specified as lport numbers, e.g. 11 for vif11. >> trim_zeros() { >> - sed 's/\(00\)\{1,\}$//' >> + sed 's/\(00\)\(00\)*$//' >> } > > I'm pretty sure this is a standard POSIX basic regular expression, see > 9.3.6 item 5 at http://pubs.opengroup.org/onlinepubs/9699919799/. > > BSD doesn't support it? hm, you are right. and sed in NetBSD seems to support it. i guess i was confused by some other things. i withdraw this patch. thank you!
diff --git a/tests/ovn.at b/tests/ovn.at index de0a830..a4dbf96 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -566,7 +566,7 @@ ovn-sbctl dump-flows -- list multicast_group # more) list the VIFs on which the packet should be received. INPORT and the # OUTPORTs are specified as lport numbers, e.g. 11 for vif11. trim_zeros() { - sed 's/\(00\)\{1,\}$//' + sed 's/\(00\)\(00\)*$//' } for i in 1 2 3; do for j in 1 2 3; do @@ -775,7 +775,7 @@ ovn-sbctl show # more) list the VIFs on which the packet should be received. INPORT and the # OUTPORTs are specified as lport numbers, e.g. 1 for vif1. trim_zeros() { - sed 's/\(00\)\{1,\}$//' + sed 's/\(00\)\(00\)*$//' } for i in 1 2 3; do : > $i.expected @@ -952,7 +952,7 @@ sleep 1 # more) list the VIFs on which the packet should be received. INPORT and the # OUTPORTs are specified as lport numbers, e.g. 11 for vif11. trim_zeros() { - sed 's/\(00\)\{1,\}$//' + sed 's/\(00\)\(00\)*$//' } for i in 1 2 3; do for j in 1 2 3; do
Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com> --- tests/ovn.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)