| Message ID | 1448391113-18628-1-git-send-email-aconole@bytheb.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Aaron Conole <aconole@bytheb.org> Date: Tue, 24 Nov 2015 13:51:53 -0500 > During pre-upstream development, the openvswitch datapath used a custom > hashtable to store vports that could fail on delete due to lack of > memory. However, prior to upstream submission, this code was reworked to > use an hlist based hastable with flexible-array based buckets. As such > the failure condition was eliminated from the vport_del path, rendering > this comment invalid. > > Signed-off-by: Aaron Conole <aconole@bytheb.org> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 0ac0fd0..e194c10a 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -256,8 +256,8 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options) * * @vport: vport to delete. * - * Detaches @vport from its datapath and destroys it. It is possible to fail - * for reasons such as lack of memory. ovs_mutex must be held. + * Detaches @vport from its datapath and destroys it. ovs_mutex must + * be held. */ void ovs_vport_del(struct vport *vport) {
During pre-upstream development, the openvswitch datapath used a custom hashtable to store vports that could fail on delete due to lack of memory. However, prior to upstream submission, this code was reworked to use an hlist based hastable with flexible-array based buckets. As such the failure condition was eliminated from the vport_del path, rendering this comment invalid. Signed-off-by: Aaron Conole <aconole@bytheb.org> --- net/openvswitch/vport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)