| Message ID | 20100412083527.GA27023@serverengines.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sathya Perla <sathyap@serverengines.com> Date: Mon, 12 Apr 2010 14:05:27 +0530 > The promiscous cmd config code gives an impression that > setting a port to promisc mode will unset the other port. > This is not the case and is clarified with a comment. > > Signed-off-by: Sathya Perla <sathyap@serverengines.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c index da87930..e79bf8b 100644 --- a/drivers/net/benet/be_cmds.c +++ b/drivers/net/benet/be_cmds.c @@ -1113,6 +1113,10 @@ int be_cmd_promiscuous_config(struct be_adapter *adapter, u8 port_num, bool en) be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_ETH, OPCODE_ETH_PROMISCUOUS, sizeof(*req)); + /* In FW versions X.102.149/X.101.487 and later, + * the port setting associated only with the + * issuing pci function will take effect + */ if (port_num) req->port1_promiscuous = en; else
The promiscous cmd config code gives an impression that setting a port to promisc mode will unset the other port. This is not the case and is clarified with a comment. Signed-off-by: Sathya Perla <sathyap@serverengines.com> --- drivers/net/benet/be_cmds.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)