| Message ID | 1446622608-22556-1-git-send-email-steven@uplinklabs.net |
|---|---|
| State | Rejected |
| Headers | show |
Dear Steven Noonan, On Tue, 3 Nov 2015 23:36:48 -0800, Steven Noonan wrote: > The only users of this feature are in package/gcc, but they were using > $(2)_TAR_EXCLUDES instead of pkg-generic's $(2)_EXCLUDES. The former name makes > more sense to me and is more readable, so let's just use that. > > Signed-off-by: Steven Noonan <steven@uplinklabs.net> Thanks for your patch. However, following your initial report, I had already fixed the problem. Moreover, your patch was making things work for gcc, but 1/ was breaking things for the external toolchain code which uses <pkg>_EXCLUDES and 2/ was not updating the Buildroot manual accordingly. Best regards, Thomas
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 1ae0315..63d72bb 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -519,7 +519,7 @@ $(2)_EXTRACT_CMDS ?= \ $$(if $$($(2)_SOURCE),$$(INFLATE$$(suffix $$($(2)_SOURCE))) $$(DL_DIR)/$$($(2)_SOURCE) | \ $$(TAR) --strip-components=$$($(2)_STRIP_COMPONENTS) \ -C $$($(2)_DIR) \ - $$(foreach x,$$($(2)_EXCLUDES),--exclude='$$(x)' ) \ + $$(foreach x,$$($(2)_TAR_EXCLUDES),--exclude='$$(x)' ) \ $$(TAR_OPTIONS) -) # pre/post-steps hooks
The only users of this feature are in package/gcc, but they were using $(2)_TAR_EXCLUDES instead of pkg-generic's $(2)_EXCLUDES. The former name makes more sense to me and is more readable, so let's just use that. Signed-off-by: Steven Noonan <steven@uplinklabs.net> --- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)