mbox

[tpmdd-devel,PULL,REQUEST] Fixes and Updates of TPM Subsystem

Message ID 201510190127.33476.PeterHuewe@gmx.de
State New
Headers show

Pull-request

https://github.com/PeterHuewe/linux-tpmdd tags/tpmdd-v4.4-updates

Message

Peter Hüwe Oct. 18, 2015, 11:27 p.m. UTC
Hi James,

I know it's superduper late, but maybe I am lucky enough.
Can you please pull the following Fixes and Updates at the earliest convenience? 
If possible even for 4.4?

Most of the patches have been lying around for a long time due to my fault -
but at least they are mature enough now.

If you cannot pull in the Updates for 4.4, maybe you can pull atleast the fixes with the tag
 tags/tpmdd-v4.4-fixes
they are critical bug fixes and should go into stable.





The following changes since commit 049e6dde7e57f0054fdc49102e7ef4830c698b46:

  Linux 4.3-rc4 (2015-10-04 16:57:17 +0100)

are available in the git repository at:

  https://github.com/PeterHuewe/linux-tpmdd tags/tpmdd-v4.4-updates

for you to fetch changes up to d72c39114c3f36785bb71aaf9dea642e59723abc:

  TPM: remove unnecessary little endian conversion (2015-10-19 01:09:31 +0200)

----------------------------------------------------------------
TPM Fixes and Updates for 4.4 Merge, incl. TPM2.0 and vTPM updates

This patch set enables distributions to start production of for TPM 2.0:
* Two critical bug fixes, including correct ACPI probing for FIFO TPMs
* PPI support
* Basic trusted keys with authentication value and SHA256 for keyed hash

and a lot of improvements for vTPM

----------------------------------------------------------------
Geert Uytterhoeven (1):
      tpm: Allow compile test of GPIO consumers if !GPIOLIB

Hon Ching \(Vicky\) Lo (6):
      vTPM: fix memory allocation flag for rtce buffer at kernel boot
      vTPM: fix searching for the right vTPM node in device tree
      vTPM: reformat event log to be byte-aligned
      vTPM: get the buffer allocated for event log instead of the actual log
      vTPM: support little endian guests
      TPM: remove unnecessary little endian conversion

Jarkko Sakkinen (10):
      tpm, tpm_crb: fix unaligned read of the command buffer address
      tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0
      sysfs: added __compat_only_sysfs_link_entry_to_kobj()
      tpm: move the PPI attributes to character device directory.
      tpm: update PPI documentation to address the location change.
      tpm: introduce tpm_buf
      keys, trusted: move struct trusted_key_options to trusted-type.h
      tpm: seal/unseal for TPM 2.0
      keys, trusted: seal/unseal with TPM 2.0 chips
      MAINTAINERS: add new maintainer for TPM DEVICE DRIVER

Krzysztof Kozlowski (1):
      char: Drop owner assignment from i2c_driver

 Documentation/ABI/testing/sysfs-driver-ppi |  19 ++-
 MAINTAINERS                                |   1 +
 arch/powerpc/kernel/prom_init.c            |  40 +++--
 drivers/char/tpm/st33zp24/Kconfig          |   2 +-
 drivers/char/tpm/st33zp24/i2c.c            |   1 -
 drivers/char/tpm/tpm-chip.c                |  24 ++-
 drivers/char/tpm/tpm-interface.c           |  76 +++++++++
 drivers/char/tpm/tpm.h                     | 134 ++++++++++++++--
 drivers/char/tpm/tpm2-cmd.c                | 250 ++++++++++++++++++++++++++++-
 drivers/char/tpm/tpm_crb.c                 |  39 ++---
 drivers/char/tpm/tpm_eventlog.c            |  78 ++++++---
 drivers/char/tpm/tpm_eventlog.h            |   6 +
 drivers/char/tpm/tpm_i2c_atmel.c           |   1 -
 drivers/char/tpm/tpm_i2c_infineon.c        |   1 -
 drivers/char/tpm/tpm_i2c_nuvoton.c         |   1 -
 drivers/char/tpm/tpm_ibmvtpm.c             |   2 +-
 drivers/char/tpm/tpm_of.c                  |   6 +-
 drivers/char/tpm/tpm_ppi.c                 |  34 ++--
 drivers/char/tpm/tpm_tis.c                 | 192 ++++++++++++++++++----
 fs/sysfs/group.c                           |  44 +++++
 include/keys/trusted-type.h                |  14 +-
 include/linux/sysfs.h                      |  11 ++
 include/linux/tpm.h                        |  26 +++
 security/keys/trusted.c                    |  36 ++++-
 security/keys/trusted.h                    |  11 --
 25 files changed, 890 insertions(+), 159 deletions(-)

------------------------------------------------------------------------------

Comments

Jarkko Sakkinen Oct. 19, 2015, 5:57 a.m. UTC | #1
Hi

On Mon, Oct 19, 2015 at 01:27:33AM +0200, Peter Hüwe wrote:
> Hi James,
> 
> I know it's superduper late, but maybe I am lucky enough.
> Can you please pull the following Fixes and Updates at the earliest convenience? 
> If possible even for 4.4?
> 
> Most of the patches have been lying around for a long time due to my fault -
> but at least they are mature enough now.

All the updates on my patches have been veryfied with four different
platforms:

* Haswell firmware TPM2 using CRB interface (tpm_crb)
* Broadwell with discrete TPM2 using FIFO interface (tpm_tis)
* Skylake with with dTPM2
* TPM 1.2 (Mimi Zohar validated that trusted keys, IMA and other key
  functionalities don't break on TPM 1.2).

At this point key thing is "doesn't break TPM 1.2" part and also to
enable it enough in the kernel so that we can start enabling it in the
user space without too many out-of-tree patches.

> If you cannot pull in the Updates for 4.4, maybe you can pull atleast the fixes with the tag
>  tags/tpmdd-v4.4-fixes
> they are critical bug fixes and should go into stable.
> 
> 
> 
> 
> 
> The following changes since commit 049e6dde7e57f0054fdc49102e7ef4830c698b46:
> 
>   Linux 4.3-rc4 (2015-10-04 16:57:17 +0100)
> 
> are available in the git repository at:
> 
>   https://github.com/PeterHuewe/linux-tpmdd tags/tpmdd-v4.4-updates
> 
> for you to fetch changes up to d72c39114c3f36785bb71aaf9dea642e59723abc:
> 
>   TPM: remove unnecessary little endian conversion (2015-10-19 01:09:31 +0200)
> 
> ----------------------------------------------------------------
> TPM Fixes and Updates for 4.4 Merge, incl. TPM2.0 and vTPM updates
> 
> This patch set enables distributions to start production of for TPM 2.0:
> * Two critical bug fixes, including correct ACPI probing for FIFO TPMs
> * PPI support
> * Basic trusted keys with authentication value and SHA256 for keyed hash
> 
> and a lot of improvements for vTPM
> 
> ----------------------------------------------------------------
> Geert Uytterhoeven (1):
>       tpm: Allow compile test of GPIO consumers if !GPIOLIB
> 
> Hon Ching \(Vicky\) Lo (6):
>       vTPM: fix memory allocation flag for rtce buffer at kernel boot
>       vTPM: fix searching for the right vTPM node in device tree
>       vTPM: reformat event log to be byte-aligned
>       vTPM: get the buffer allocated for event log instead of the actual log
>       vTPM: support little endian guests
>       TPM: remove unnecessary little endian conversion
> 
> Jarkko Sakkinen (10):
>       tpm, tpm_crb: fix unaligned read of the command buffer address
>       tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0
>       sysfs: added __compat_only_sysfs_link_entry_to_kobj()
>       tpm: move the PPI attributes to character device directory.
>       tpm: update PPI documentation to address the location change.
>       tpm: introduce tpm_buf
>       keys, trusted: move struct trusted_key_options to trusted-type.h
>       tpm: seal/unseal for TPM 2.0
>       keys, trusted: seal/unseal with TPM 2.0 chips
>       MAINTAINERS: add new maintainer for TPM DEVICE DRIVER
> 
> Krzysztof Kozlowski (1):
>       char: Drop owner assignment from i2c_driver
> 
>  Documentation/ABI/testing/sysfs-driver-ppi |  19 ++-
>  MAINTAINERS                                |   1 +
>  arch/powerpc/kernel/prom_init.c            |  40 +++--
>  drivers/char/tpm/st33zp24/Kconfig          |   2 +-
>  drivers/char/tpm/st33zp24/i2c.c            |   1 -
>  drivers/char/tpm/tpm-chip.c                |  24 ++-
>  drivers/char/tpm/tpm-interface.c           |  76 +++++++++
>  drivers/char/tpm/tpm.h                     | 134 ++++++++++++++--
>  drivers/char/tpm/tpm2-cmd.c                | 250 ++++++++++++++++++++++++++++-
>  drivers/char/tpm/tpm_crb.c                 |  39 ++---
>  drivers/char/tpm/tpm_eventlog.c            |  78 ++++++---
>  drivers/char/tpm/tpm_eventlog.h            |   6 +
>  drivers/char/tpm/tpm_i2c_atmel.c           |   1 -
>  drivers/char/tpm/tpm_i2c_infineon.c        |   1 -
>  drivers/char/tpm/tpm_i2c_nuvoton.c         |   1 -
>  drivers/char/tpm/tpm_ibmvtpm.c             |   2 +-
>  drivers/char/tpm/tpm_of.c                  |   6 +-
>  drivers/char/tpm/tpm_ppi.c                 |  34 ++--
>  drivers/char/tpm/tpm_tis.c                 | 192 ++++++++++++++++++----
>  fs/sysfs/group.c                           |  44 +++++
>  include/keys/trusted-type.h                |  14 +-
>  include/linux/sysfs.h                      |  11 ++
>  include/linux/tpm.h                        |  26 +++
>  security/keys/trusted.c                    |  36 ++++-
>  security/keys/trusted.h                    |  11 --
>  25 files changed, 890 insertions(+), 159 deletions(-)

/Jarkko

------------------------------------------------------------------------------
James Morris Oct. 19, 2015, 12:41 p.m. UTC | #2
On Mon, 19 Oct 2015, Peter Hüwe wrote:

> Hi James,
> 
> I know it's superduper late, but maybe I am lucky enough.
> Can you please pull the following Fixes and Updates at the earliest convenience? 
> If possible even for 4.4?
> 
> Most of the patches have been lying around for a long time due to my fault -
> but at least they are mature enough now.
> 

Pulled, thanks.