diff mbox

ui/cocoa.m: blinky mouse cursor fix

Message ID AAA87DD7-EC20-4F4B-B71E-C38461D9FCBA@gmail.com
State New
Headers show

Commit Message

Programmingkid Sept. 27, 2015, 1:32 a.m. UTC
The mouse cursor can become blinky when being moved a lot. This patch fixes that
problem by issuing the redraw sooner. 

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>

---
 ui/cocoa.m |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Peter Maydell Oct. 13, 2015, 8:35 p.m. UTC | #1
On 27 September 2015 at 02:32, Programmingkid <programmingkidx@gmail.com> wrote:
> The mouse cursor can become blinky when being moved a lot. This patch fixes that
> problem by issuing the redraw sooner.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>
> ---
>  ui/cocoa.m |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 334e6f6..cf372a4 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -1275,6 +1275,7 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
>      NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
>
>      COCOA_DEBUG("qemu_cocoa: cocoa_refresh\n");
> +    graphic_hw_update(NULL);
>
>      if (qemu_input_is_absolute()) {
>          if (![cocoaView isAbsoluteEnabled]) {
> @@ -1295,7 +1296,6 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
>              [cocoaView handleEvent:event];
>          }
>      } while(event != nil);
> -    graphic_hw_update(NULL);
>      [pool release];
>  }
>
> --
> 1.7.5.4

Thanks, applied to cocoa.next. (This brings us into line with
the other UI front ends which update the graphics first and
process events second.)

-- PMM
diff mbox

Patch

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 334e6f6..cf372a4 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1275,6 +1275,7 @@  static void cocoa_refresh(DisplayChangeListener *dcl)
     NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
 
     COCOA_DEBUG("qemu_cocoa: cocoa_refresh\n");
+    graphic_hw_update(NULL);
 
     if (qemu_input_is_absolute()) {
         if (![cocoaView isAbsoluteEnabled]) {
@@ -1295,7 +1296,6 @@  static void cocoa_refresh(DisplayChangeListener *dcl)
             [cocoaView handleEvent:event];
         }
     } while(event != nil);
-    graphic_hw_update(NULL);
     [pool release];
 }