diff mbox

[v2] toolchain: Fix glibc breakage

Message ID 1443958508-5943-1-git-send-email-maxime.hadjinlian@gmail.com
State Accepted
Commit 8f59da855207b5e271f826f37e246b6e27b8c9d0
Headers show

Commit Message

Maxime Hadjinlian Oct. 4, 2015, 11:35 a.m. UTC
Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c,
this printf would break the build of glibc, because there is no format
to printf:

    printf: usage: printf [-v var] format [arguments]

Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 toolchain/helpers.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Yann E. MORIN Oct. 4, 2015, 11:46 a.m. UTC | #1
Maxime, All,

On 2015-10-04 13:35 +0200, Maxime Hadjinlian spake thusly:
> Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c,
> this printf would break the build of glibc, because there is no format
> to printf:

Better, thanks! :-)

>     printf: usage: printf [-v var] format [arguments]
> 
> Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Still valid.

Regards,
Yann E. MORIN.

> ---
>  toolchain/helpers.mk | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index a4fa815..1452ec6 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -79,9 +79,7 @@ copy_toolchain_lib_root = \
>  			fi ; \
>  			LIBPATH="`readlink -f $${LIBPATH}`"; \
>  		done; \
> -	done; \
> -\
> -	printf
> +	done
>  
>  #
>  # Copy the full external toolchain sysroot directory to the staging
> -- 
> 2.5.3
>
Peter Korsgaard Oct. 4, 2015, noon UTC | #2
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c,
 > this printf would break the build of glibc, because there is no format
 > to printf:

 >     printf: usage: printf [-v var] format [arguments]

 > Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
 > Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed, thanks.
diff mbox

Patch

diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a4fa815..1452ec6 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -79,9 +79,7 @@  copy_toolchain_lib_root = \
 			fi ; \
 			LIBPATH="`readlink -f $${LIBPATH}`"; \
 		done; \
-	done; \
-\
-	printf
+	done
 
 #
 # Copy the full external toolchain sysroot directory to the staging