Message ID | 1443445533-14474-1-git-send-email-alexander.stein@systec-electronic.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On 28/09/15 14:05, Alexander Stein wrote: > Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link. > Documentation/ABI/testing/sysfs-class-net does not state if this shall be > signed or unsigned. > Also remove the now unused variable fmt_udec. [...] > - ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd)); > + ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd)); If we print anything numeric, why is zero not appropriate (which would still be unsigned)?
From: Alexander Stein <alexander.stein@systec-electronic.com> Date: Mon, 28 Sep 2015 15:05:33 +0200 > Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link. > Documentation/ABI/testing/sysfs-class-net does not state if this shall be > signed or unsigned. > Also remove the now unused variable fmt_udec. > > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 805a95a..830f8a7 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -31,7 +31,6 @@ static const char fmt_hex[] = "%#x\n"; static const char fmt_long_hex[] = "%#lx\n"; static const char fmt_dec[] = "%d\n"; -static const char fmt_udec[] = "%u\n"; static const char fmt_ulong[] = "%lu\n"; static const char fmt_u64[] = "%llu\n"; @@ -202,7 +201,7 @@ static ssize_t speed_show(struct device *dev, if (netif_running(netdev)) { struct ethtool_cmd cmd; if (!__ethtool_get_settings(netdev, &cmd)) - ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd)); + ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd)); } rtnl_unlock(); return ret;
Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link. Documentation/ABI/testing/sysfs-class-net does not state if this shall be signed or unsigned. Also remove the now unused variable fmt_udec. Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> --- Changes in v2: * Switch the format specifier instead of changing it * Remove the now unused variable net/core/net-sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)