| Message ID | 1441721106-27234-1-git-send-email-brendanheading@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 08-09-15 16:05, Brendan Heading wrote: > Fixes : > > http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/ > > .. and many others. > > host-gdb is broken on all architectures at the moment, as it seems to > require makeinfo during "make install" even if configure > failed to detect it. Instead of trying to hack it, let's simply make gdb > dependent on host-texinfo. Any idea why this is not needed for target gdb? Regards, Arnout > > Signed-off-by: Brendan Heading <brendanheading@gmail.com> > --- > package/gdb/gdb.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk > index 338de20..efe195a 100644 > --- a/package/gdb/gdb.mk > +++ b/package/gdb/gdb.mk > @@ -40,7 +40,7 @@ endif > # For the host variant, we really want to build with XML support, > # which is needed to read XML descriptions of target architectures. We > # also need ncurses. > -HOST_GDB_DEPENDENCIES = host-expat host-ncurses > +HOST_GDB_DEPENDENCIES = host-expat host-ncurses host-texinfo > > # Apply the Xtensa specific patches > XTENSA_CORE_NAME = $(call qstrip, $(BR2_XTENSA_CORE_NAME)) >
>> host-gdb is broken on all architectures at the moment, as it seems to >> require makeinfo during "make install" even if configure >> failed to detect it. Instead of trying to hack it, let's simply make gdb >> dependent on host-texinfo. > > Any idea why this is not needed for target gdb? Good point, I expect that it is - I will check and resubmit. Brendan
Dear Arnout Vandecappelle, On 09/08/2015 03:13 PM, Arnout Vandecappelle wrote: > On 08-09-15 16:05, Brendan Heading wrote: >> Fixes : >> >> http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/ >> >> .. and many others. >> >> host-gdb is broken on all architectures at the moment, as it seems to >> require makeinfo during "make install" even if configure >> failed to detect it. Instead of trying to hack it, let's simply make gdb >> dependent on host-texinfo. > > Any idea why this is not needed for target gdb? It is needed for the target as well. You can build the target gdb without building the host gdb, in which case the host-texinfo package would not be installed and you would face the failure again. Brendan, please, can you add the dependency for target gdb as well? Regards, Vincent. > Regards, > Arnout > >> >> Signed-off-by: Brendan Heading <brendanheading@gmail.com> >> --- >> package/gdb/gdb.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk >> index 338de20..efe195a 100644 >> --- a/package/gdb/gdb.mk >> +++ b/package/gdb/gdb.mk >> @@ -40,7 +40,7 @@ endif >> # For the host variant, we really want to build with XML support, >> # which is needed to read XML descriptions of target architectures. We >> # also need ncurses. >> -HOST_GDB_DEPENDENCIES = host-expat host-ncurses >> +HOST_GDB_DEPENDENCIES = host-expat host-ncurses host-texinfo >> >> # Apply the Xtensa specific patches >> XTENSA_CORE_NAME = $(call qstrip, $(BR2_XTENSA_CORE_NAME)) >> > >
> It is needed for the target as well. You can build the target gdb > without building the host gdb, in which case the host-texinfo package > would not be installed and you would face the failure again. > > Brendan, please, can you add the dependency for target gdb as well? I'm looking at it, but strangely, I'm not able to reproduce the same problem with target GDB - it appears to build just fine without the texinfo dependency. Looking into why, and will submit an updated patch when I crack it. Probably a difference with the config, or there's a patch being added somewhere. Brendan
Dear Brendan Heading, On 09/08/2015 03:41 PM, Brendan Heading wrote: >> It is needed for the target as well. You can build the target gdb >> without building the host gdb, in which case the host-texinfo package >> would not be installed and you would face the failure again. >> >> Brendan, please, can you add the dependency for target gdb as well? > > I'm looking at it, but strangely, I'm not able to reproduce the same > problem with target GDB - it appears to build just fine without the > texinfo dependency. > > Looking into why, and will submit an updated patch when I crack it. > Probably a difference with the config, or there's a patch being added > somewhere. Perhaps you trying to build the target gdb in the same buildroot tree where you have built the host gdb? (which will have makeinfo available because host-texinfo has been built). Regards, Vincent. > Brendan >
>> Looking into why, and will submit an updated patch when I crack it. >> Probably a difference with the config, or there's a patch being added >> somewhere. > > Perhaps you trying to build the target gdb in the same buildroot tree > where you have built the host gdb? (which will have makeinfo available > because host-texinfo has been built). No, host-texinfo is not being built at all. I found the cause - by default the full gdb is not built, only gdbserver. It seems that a gdbserver-only build does not trigger the documentation element of "make install" in gdb. I need to make a better patch as there's already logic in the build to only depend on texinfo under certain circumstances - and I also need to test all the combinations (three different GDB versions are supported). Hopefully will send it through today. regards Brendan
Dear Brendan Heading, On 09/08/2015 03:53 PM, Brendan Heading wrote: >>> Looking into why, and will submit an updated patch when I crack it. >>> Probably a difference with the config, or there's a patch being added >>> somewhere. >> >> Perhaps you trying to build the target gdb in the same buildroot tree >> where you have built the host gdb? (which will have makeinfo available >> because host-texinfo has been built). > > No, host-texinfo is not being built at all. > > I found the cause - by default the full gdb is not built, only > gdbserver. It seems that a gdbserver-only build does not trigger the > documentation element of "make install" in gdb. Indeed, I was reproducing the autobuild failure with the full gdb. > I need to make a better patch as there's already logic in the build to > only depend on texinfo under certain circumstances - and I also need > to test all the combinations (three different GDB versions are > supported). Hopefully will send it through today. When you do it, could you please use a better subject? "fix autobuild failure" doesn't give any information about what the patch does. "host-texinfo needed for full gdb" gives more information, for instance. Regards, Vincent. > regards > > Brendan >
diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk index 338de20..efe195a 100644 --- a/package/gdb/gdb.mk +++ b/package/gdb/gdb.mk @@ -40,7 +40,7 @@ endif # For the host variant, we really want to build with XML support, # which is needed to read XML descriptions of target architectures. We # also need ncurses. -HOST_GDB_DEPENDENCIES = host-expat host-ncurses +HOST_GDB_DEPENDENCIES = host-expat host-ncurses host-texinfo # Apply the Xtensa specific patches XTENSA_CORE_NAME = $(call qstrip, $(BR2_XTENSA_CORE_NAME))
Fixes : http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/ .. and many others. host-gdb is broken on all architectures at the moment, as it seems to require makeinfo during "make install" even if configure failed to detect it. Instead of trying to hack it, let's simply make gdb dependent on host-texinfo. Signed-off-by: Brendan Heading <brendanheading@gmail.com> --- package/gdb/gdb.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)