diff mbox

[PR64164] drop copyrename, integrate into expand

Message ID oregixxee8.fsf@livre.home
State New
Headers show

Commit Message

Alexandre Oliva Aug. 21, 2015, 7:57 a.m. UTC 
On Aug 19, 2015, Alexandre Oliva <aoliva@redhat.com> wrote:

> I have verified in the expand dumps that both the gimple and the rtl
> representation in the relevant parts of the code are identical, except
> for the presence of debug stmts and insns.

While comparing the dumps, I noticed -fdump-unnumbered-links no longer
worked like it did back when I introduced it, with the very purpose of
making it easier to compare dumps with and without debug insns.

When the insn_uid was moved out of the u[] array, the indices that
print-rtl tested to tell whether to omit the ids of the prev and next
insns got off by one.

This patch updates the test to match the current indices.

Bootstrapping on ia64-linux-gnu.  Ok to install?

fix -fdump-unnumbered-links

From: Alexandre Oliva <aoliva@redhat.com>

for  gcc/ChangeLog

	* print-rtl.c (print_rtx): Check the correct range for
	flag_dump_unnumbered_links to behave as documented.
---
 gcc/print-rtl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Biener Aug. 21, 2015, 8:35 a.m. UTC | #1 
On Fri, Aug 21, 2015 at 9:57 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Aug 19, 2015, Alexandre Oliva <aoliva@redhat.com> wrote:
>
>> I have verified in the expand dumps that both the gimple and the rtl
>> representation in the relevant parts of the code are identical, except
>> for the presence of debug stmts and insns.
>
> While comparing the dumps, I noticed -fdump-unnumbered-links no longer
> worked like it did back when I introduced it, with the very purpose of
> making it easier to compare dumps with and without debug insns.
>
> When the insn_uid was moved out of the u[] array, the indices that
> print-rtl tested to tell whether to omit the ids of the prev and next
> insns got off by one.
>
> This patch updates the test to match the current indices.
>
> Bootstrapping on ia64-linux-gnu.  Ok to install?

Ok.

Thanks,
Richard.

> fix -fdump-unnumbered-links
>
> From: Alexandre Oliva <aoliva@redhat.com>
>
> for  gcc/ChangeLog
>
>         * print-rtl.c (print_rtx): Check the correct range for
>         flag_dump_unnumbered_links to behave as documented.
> ---
>  gcc/print-rtl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/print-rtl.c b/gcc/print-rtl.c
> index aacadbb..b541d83 100644
> --- a/gcc/print-rtl.c
> +++ b/gcc/print-rtl.c
> @@ -550,7 +550,7 @@ print_rtx (const_rtx in_rtx)
>               }
>
>             if (flag_dump_unnumbered
> -               || (flag_dump_unnumbered_links && (i == 1 || i == 2)
> +               || (flag_dump_unnumbered_links && i <= 1
>                     && (INSN_P (in_rtx) || NOTE_P (in_rtx)
>                         || LABEL_P (in_rtx) || BARRIER_P (in_rtx))))
>               fputs (" #", outfile);
>
>
> --
> Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
> You must be the change you wish to see in the world. -- Gandhi
> Be Free! -- http://FSFLA.org/   FSF Latin America board member
> Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
diff mbox

Patch

diff --git a/gcc/print-rtl.c b/gcc/print-rtl.c
index aacadbb..b541d83 100644
--- a/gcc/print-rtl.c
+++ b/gcc/print-rtl.c
@@ -550,7 +550,7 @@  print_rtx (const_rtx in_rtx)
 	      }
 
 	    if (flag_dump_unnumbered
-		|| (flag_dump_unnumbered_links && (i == 1 || i == 2)
+		|| (flag_dump_unnumbered_links && i <= 1
 		    && (INSN_P (in_rtx) || NOTE_P (in_rtx)
 			|| LABEL_P (in_rtx) || BARRIER_P (in_rtx))))
 	      fputs (" #", outfile);