diff mbox

IPv6: better document max_addresses parameter

Message ID 4B8304C9.1030800@hp.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Brian Haley Feb. 22, 2010, 10:27 p.m. UTC
Andrew Morton wrote:
>> >From ip-sysctl.txt file in kernel documentation I can see following description
>> for max_addresses:
>> max_addresses - INTEGER
>>         Number of maximum addresses per interface.  0 disables limitation.
>>         It is recommended not set too large value (or 0) because it would
>>         be too easy way to crash kernel to allow to create too much of
>>         autoconfigured addresses.
           ^^^^^^^^^^^^^^

>> If this parameter applies only for auto-configured IP addressed, please state
>> it more clearly in docs or rename the parameter to show that it refers to
>> auto-configuration.

It did mention autoconfigured in the text, but the below makes it more obvious.


More clearly document IPv6 max_addresses parameter.

Signed-off-by: Brian Haley <brian.haley@hp.com>
---

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Feb. 23, 2010, 9:25 a.m. UTC | #1
From: Brian Haley <brian.haley@hp.com>
Date: Mon, 22 Feb 2010 17:27:21 -0500

> Andrew Morton wrote:
>>> >From ip-sysctl.txt file in kernel documentation I can see following description
>>> for max_addresses:
>>> max_addresses - INTEGER
>>>         Number of maximum addresses per interface.  0 disables limitation.
>>>         It is recommended not set too large value (or 0) because it would
>>>         be too easy way to crash kernel to allow to create too much of
>>>         autoconfigured addresses.
>            ^^^^^^^^^^^^^^
> 
>>> If this parameter applies only for auto-configured IP addressed, please state
>>> it more clearly in docs or rename the parameter to show that it refers to
>>> auto-configuration.
> 
> It did mention autoconfigured in the text, but the below makes it more obvious.
> 
> 
> More clearly document IPv6 max_addresses parameter.
> 
> Signed-off-by: Brian Haley <brian.haley@hp.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 2571a62..8b72c88 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -1126,10 +1126,10 @@  regen_max_retry - INTEGER
 	Default: 5
 
 max_addresses - INTEGER
-	Number of maximum addresses per interface.  0 disables limitation.
-	It is recommended not set too large value (or 0) because it would
-	be too easy way to crash kernel to allow to create too much of
-	autoconfigured addresses.
+	Maximum number of autoconfigured addresses per interface.  Setting
+	to zero disables the limitation.  It is not recommended to set this
+	value too large (or to zero) because it would be an easy way to
+	crash the kernel by allowing too many addresses to be created.
 	Default: 16
 
 disable_ipv6 - BOOLEAN