| Message ID | 9a73202315e0a236b78d9644905c20b79572f93d.1432015191.git.sam.bobroff@au1.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
Le 19/05/2015 07:59, Sam Bobroff a écrit : > Now that librtas is available, optionally use it with powerpc-utils to > enable it's RTAS dependant functionality. It is used by default, as > most distros do, but made optional because it adds several new programs > and significantly increases the size of the installed package. > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> > --- > v3: > > Group "with" and "without" clauses. > > v2: > > Make librtas support in powerpc-utils optional due to size concerns. > > package/powerpc-utils/Config.in | 18 ++++++++++++++++++ > package/powerpc-utils/powerpc-utils.mk | 8 +++++++- > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/package/powerpc-utils/Config.in b/package/powerpc-utils/Config.in > index eded41e..8b3e3d1 100644 > --- a/package/powerpc-utils/Config.in > +++ b/package/powerpc-utils/Config.in > @@ -6,3 +6,21 @@ config BR2_PACKAGE_POWERPC_UTILS > System utilities for PowerPC machines. > > http://sourceforge.net/projects/powerpc-utils/ > + > +if BR2_PACKAGE_POWERPC_UTILS > + > +config BR2_PACKAGE_POWERPC_UTILS_RTAS > + bool "RTAS support" > + select BR2_PACKAGE_LIBRTAS The librtas reverse dependencies should be added here (glibc toolchain only and !static build) Reviewed-by: Romain Naour <romain.naour@openwide.fr> Best regards, Romain Naour > + default y > + help > + Enable support for functions that require RTAS. > + > + This adds a dependency on librtas and provides the following > + additional features at the cost of increasing the installed package > + size from about 0.5MB to about 2MB: > + ppc64_cpu --run-mode, uesensor, set_poweron_time, drmgr, lsslot, > + activate_firmware, rtas_ibm_get_vpd, serv_config, > + rtas_event_decode, sys_ident. > + > +endif > diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk > index 3b30458..ae4d662 100644 > --- a/package/powerpc-utils/powerpc-utils.mk > +++ b/package/powerpc-utils/powerpc-utils.mk > @@ -10,8 +10,14 @@ POWERPC_UTILS_DEPENDENCIES = zlib > POWERPC_UTILS_LICENSE = Common Public License Version 1.0 > POWERPC_UTILS_LICENSE_FILES = COPYRIGHT > > -POWERPC_UTILS_CONF_OPTS = --without-librtas > POWERPC_UTILS_CONF_ENV = \ > ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) > > +ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y) > +POWERPC_UTILS_DEPENDENCIES += librtas > +POWERPC_UTILS_CONF_OPTS = --with-librtas > +else > +POWERPC_UTILS_CONF_OPTS = --without-librtas > +endif > + > $(eval $(autotools-package)) >
Dear Sam Bobroff, On Tue, 19 May 2015 15:59:56 +1000, Sam Bobroff wrote: > Now that librtas is available, optionally use it with powerpc-utils to > enable it's RTAS dependant functionality. It is used by default, as > most distros do, but made optional because it adds several new programs > and significantly increases the size of the installed package. > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> > --- > v3: Applied after propagating the glibc dependency of librtas, as noted by Romain Naour. Thanks! Thomas
On Mon, Jul 13, 2015 at 06:44:18PM +0200, Thomas Petazzoni wrote: > Dear Sam Bobroff, > > On Tue, 19 May 2015 15:59:56 +1000, Sam Bobroff wrote: > > Now that librtas is available, optionally use it with powerpc-utils to > > enable it's RTAS dependant functionality. It is used by default, as > > most distros do, but made optional because it adds several new programs > > and significantly increases the size of the installed package. > > > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> > > --- > > v3: > > Applied after propagating the glibc dependency of librtas, as noted by > Romain Naour. > > Thanks! > > Thomas Baruch, Romain and Thomas, Thanks for the reviews and improvements! Cheers, Sam.
diff --git a/package/powerpc-utils/Config.in b/package/powerpc-utils/Config.in index eded41e..8b3e3d1 100644 --- a/package/powerpc-utils/Config.in +++ b/package/powerpc-utils/Config.in @@ -6,3 +6,21 @@ config BR2_PACKAGE_POWERPC_UTILS System utilities for PowerPC machines. http://sourceforge.net/projects/powerpc-utils/ + +if BR2_PACKAGE_POWERPC_UTILS + +config BR2_PACKAGE_POWERPC_UTILS_RTAS + bool "RTAS support" + select BR2_PACKAGE_LIBRTAS + default y + help + Enable support for functions that require RTAS. + + This adds a dependency on librtas and provides the following + additional features at the cost of increasing the installed package + size from about 0.5MB to about 2MB: + ppc64_cpu --run-mode, uesensor, set_poweron_time, drmgr, lsslot, + activate_firmware, rtas_ibm_get_vpd, serv_config, + rtas_event_decode, sys_ident. + +endif diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk index 3b30458..ae4d662 100644 --- a/package/powerpc-utils/powerpc-utils.mk +++ b/package/powerpc-utils/powerpc-utils.mk @@ -10,8 +10,14 @@ POWERPC_UTILS_DEPENDENCIES = zlib POWERPC_UTILS_LICENSE = Common Public License Version 1.0 POWERPC_UTILS_LICENSE_FILES = COPYRIGHT -POWERPC_UTILS_CONF_OPTS = --without-librtas POWERPC_UTILS_CONF_ENV = \ ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) +ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y) +POWERPC_UTILS_DEPENDENCIES += librtas +POWERPC_UTILS_CONF_OPTS = --with-librtas +else +POWERPC_UTILS_CONF_OPTS = --without-librtas +endif + $(eval $(autotools-package))
Now that librtas is available, optionally use it with powerpc-utils to enable it's RTAS dependant functionality. It is used by default, as most distros do, but made optional because it adds several new programs and significantly increases the size of the installed package. Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> --- v3: Group "with" and "without" clauses. v2: Make librtas support in powerpc-utils optional due to size concerns. package/powerpc-utils/Config.in | 18 ++++++++++++++++++ package/powerpc-utils/powerpc-utils.mk | 8 +++++++- 2 files changed, 25 insertions(+), 1 deletion(-)