| Message ID | 1437137197-5278-1-git-send-email-joerg.krause@embedded.rocks |
|---|---|
| State | Accepted |
| Headers | show |
Jörg, On Fri, 17 Jul 2015 14:46:37 +0200, Jörg Krause wrote: > luajit requires dlopen(). > > Fixes: > http://autobuild.buildroot.net/results/20d/20dfb10198f3688f92208591960192ca08280987/ > http://autobuild.buildroot.net/results/c3c/c3cfdf8dfb315bf64caa9ed0f362016111fd93ac/ > http://autobuild.buildroot.net/results/8cb/8cbf6207ecf7b254aeccd9ec5c07376a044e1f8f/ > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > --- > package/luajit/Config.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/luajit/Config.in b/package/luajit/Config.in > index f6995e2..8ce528b 100644 > --- a/package/luajit/Config.in > +++ b/package/luajit/Config.in > @@ -8,6 +8,7 @@ config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS > config BR2_PACKAGE_LUAJIT > bool "luajit" > select BR2_PACKAGE_HAS_LUAINTERPRETER > + depends on !BR2_STATIC_LIBS # dlopen You forgot to propagate this dependency to the sysdig package, which selects luajit, so I've done that an applied. Technically speaking, it is possible to build luajit in BR2_STATIC_LIBS=y configuration, by setting LJ_TARGET_DLOPEN to 0 in src/lj_arch.h, but then you cannot load any C module, which makes LuaJIT maybe a little bit useless. If anyone is interested, they can always work on making this change. Thanks! Thomas
diff --git a/package/luajit/Config.in b/package/luajit/Config.in index f6995e2..8ce528b 100644 --- a/package/luajit/Config.in +++ b/package/luajit/Config.in @@ -8,6 +8,7 @@ config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS config BR2_PACKAGE_LUAJIT bool "luajit" select BR2_PACKAGE_HAS_LUAINTERPRETER + depends on !BR2_STATIC_LIBS # dlopen # Luajit is only available for some target architectures, and # has some complexity wrt 32/64. See luajit.mk for details. depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS @@ -32,3 +33,6 @@ config BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION default "5.1" endif + +comment "luajit needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
luajit requires dlopen(). Fixes: http://autobuild.buildroot.net/results/20d/20dfb10198f3688f92208591960192ca08280987/ http://autobuild.buildroot.net/results/c3c/c3cfdf8dfb315bf64caa9ed0f362016111fd93ac/ http://autobuild.buildroot.net/results/8cb/8cbf6207ecf7b254aeccd9ec5c07376a044e1f8f/ Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- package/luajit/Config.in | 4 ++++ 1 file changed, 4 insertions(+)