| Message ID | 1428271811-27530-1-git-send-email-ryanbarnett3@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Ryan, On Sun, Apr 05, 2015 at 05:10:10PM -0500, Ryan Barnett wrote: > In the future when the kernel offically supports kdbus, this option > should automatically enable the kernel kdbus config option(s). So there is no need to fiddle with kernel version dependency for --enable-kdbus? [...] > +ifeq ($(BR2_PACKAGE_SYSTEMD_KDBUS),y) > +SYSTEMD_CONF_OPTS += --enable-kdbus > +else > +SYSTEMD_CONF_OPTS += --disable-kdbus > +endif Is there any reason not to enable kdbus when the kernel supports that? If not, I'd suggest to add --enable-kdbus unconditionally, and remove BR2_PACKAGE_SYSTEMD_KDBUS. baruch
Baruch, On Mon, Apr 6, 2015 at 12:04 AM, Baruch Siach <baruch@tkos.co.il> wrote: > Hi Ryan, > > On Sun, Apr 05, 2015 at 05:10:10PM -0500, Ryan Barnett wrote: >> In the future when the kernel offically supports kdbus, this option >> should automatically enable the kernel kdbus config option(s). > > So there is no need to fiddle with kernel version dependency for > --enable-kdbus? To be honest, this is the first time I ever used systemd with buildroot and I really don't know how kdbus integrates with it. The real reason that the kdbus support is needed for miraclecast is for it to install headers that it depends on "systemd/sd-events.h". I've build the raspberry pi kernel and a vanilla 3.19 (QEMU x86) kernel with systemd with the --enable-kdbus and it compiled and installed the required headers I needed. So it appears that you can enable kdbus without the kernel side support. There also isn't anything (that I can find) in the systemd documentation saying that the kernel side kdbus support is required. If anyone can help clarify this I would appreciate since I am by no means knowledge in this area. >> +ifeq ($(BR2_PACKAGE_SYSTEMD_KDBUS),y) >> +SYSTEMD_CONF_OPTS += --enable-kdbus >> +else >> +SYSTEMD_CONF_OPTS += --disable-kdbus >> +endif > > Is there any reason not to enable kdbus when the kernel supports that? If not, > I'd suggest to add --enable-kdbus unconditionally, and remove > BR2_PACKAGE_SYSTEMD_KDBUS. In the future, I would agree with this. However, as I stated above, it appears that systemd can be compiled with kdbus support without having the kernel side feature enabled. With kdbus in systemd being able to enabled with the kernel kdbus support, I would be in favor of keeping this BR2_PACKAGE_SYSTEMD_KDBUS option. Thanks, -Ryan
All, Tested-by: Mike Williams <mike@mikebwilliams.com> >> Is there any reason not to enable kdbus when the kernel supports that? If not, >> I'd suggest to add --enable-kdbus unconditionally, and remove >> BR2_PACKAGE_SYSTEMD_KDBUS. > > In the future, I would agree with this. However, as I stated above, it > appears that systemd can be compiled with kdbus support without having > the kernel side feature enabled. With kdbus in systemd being able to > enabled with the kernel kdbus support, I would be in favor of keeping > this BR2_PACKAGE_SYSTEMD_KDBUS option. I'm actually using this patch as is, and it works for me. I also do not have kdbus enabled in the kernel, and am only using this support to get additional libraries provided by systemd for Thanks, Mike
Dear Ryan Barnett, On Sun, 5 Apr 2015 17:10:10 -0500, Ryan Barnett wrote: > In the future when the kernel offically supports kdbus, this option > should automatically enable the kernel kdbus config option(s). > > Signed-off-by: Ryan Barnett <ryanbarnett3@gmail.com> > --- > package/systemd/Config.in | 5 +++++ > package/systemd/systemd.mk | 6 ++++++ > 2 files changed, 11 insertions(+) Applied, thanks. Thomas
diff --git a/package/systemd/Config.in b/package/systemd/Config.in index d00ac9d..0543b76 100644 --- a/package/systemd/Config.in +++ b/package/systemd/Config.in @@ -71,6 +71,11 @@ config BR2_PACKAGE_SYSTEMD_ALL_EXTRAS Enable extra features for Systemd: journal compression and signing. +config BR2_PACKAGE_SYSTEMD_KDBUS + bool "enable kdbus support" + help + Enable kdbus support for Systemd. + config BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY bool "HTTP server for journal events" select BR2_PACKAGE_LIBMICROHTTPD diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk index 98bda02..81fe434 100644 --- a/package/systemd/systemd.mk +++ b/package/systemd/systemd.mk @@ -77,6 +77,12 @@ else SYSTEMD_CONF_OPTS += --disable-seccomp endif +ifeq ($(BR2_PACKAGE_SYSTEMD_KDBUS),y) +SYSTEMD_CONF_OPTS += --enable-kdbus +else +SYSTEMD_CONF_OPTS += --disable-kdbus +endif + ifeq ($(BR2_PACKAGE_SYSTEMD_ALL_EXTRAS),y) SYSTEMD_DEPENDENCIES += \ xz \
In the future when the kernel offically supports kdbus, this option should automatically enable the kernel kdbus config option(s). Signed-off-by: Ryan Barnett <ryanbarnett3@gmail.com> --- package/systemd/Config.in | 5 +++++ package/systemd/systemd.mk | 6 ++++++ 2 files changed, 11 insertions(+)