| Message ID | e64f1903478b53f185f3bf114f86c46948a31311.1435886073.git.sam.bobroff@au1.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On 07/03/15 03:14, Sam Bobroff wrote: > host-libtool can fail to build if the host is missing makeinfo, so > disable it. > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > --- > Without this patch, buildroot fails to build host-libtool on my Debian > 8 system, as it doesn't have the texinfo package installed. > > package/libtool/libtool.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/libtool/libtool.mk b/package/libtool/libtool.mk > index 28786d2..8688f8b 100644 > --- a/package/libtool/libtool.mk > +++ b/package/libtool/libtool.mk > @@ -13,6 +13,7 @@ LIBTOOL_DEPENDENCIES = host-m4 > LIBTOOL_LICENSE = GPLv2+ > LIBTOOL_LICENSE_FILES = COPYING > > +HOST_LIBTOOL_CONF_ENV = MAKEINFO=true > HOST_LIBTOOL_LIBTOOL_PATCH = NO > > # We have a patch that affects libtool.m4, which triggers an autoreconf >
Sam, All, On 2015-07-03 11:14 +1000, Sam Bobroff spake thusly: > host-libtool can fail to build if the host is missing makeinfo, so > disable it. > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > Without this patch, buildroot fails to build host-libtool on my Debian > 8 system, as it doesn't have the texinfo package installed. > > package/libtool/libtool.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/libtool/libtool.mk b/package/libtool/libtool.mk > index 28786d2..8688f8b 100644 > --- a/package/libtool/libtool.mk > +++ b/package/libtool/libtool.mk > @@ -13,6 +13,7 @@ LIBTOOL_DEPENDENCIES = host-m4 > LIBTOOL_LICENSE = GPLv2+ > LIBTOOL_LICENSE_FILES = COPYING > > +HOST_LIBTOOL_CONF_ENV = MAKEINFO=true > HOST_LIBTOOL_LIBTOOL_PATCH = NO > > # We have a patch that affects libtool.m4, which triggers an autoreconf > -- > 2.1.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Sam Bobroff, On Fri, 3 Jul 2015 11:14:38 +1000, Sam Bobroff wrote: > host-libtool can fail to build if the host is missing makeinfo, so > disable it. > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> > --- > Without this patch, buildroot fails to build host-libtool on my Debian > 8 system, as it doesn't have the texinfo package installed. Applied, thanks. Thomas
On 07/04/15 12:45, Thomas Petazzoni wrote: > Dear Sam Bobroff, > > On Fri, 3 Jul 2015 11:14:38 +1000, Sam Bobroff wrote: >> host-libtool can fail to build if the host is missing makeinfo, so >> disable it. >> >> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> >> --- >> Without this patch, buildroot fails to build host-libtool on my Debian >> 8 system, as it doesn't have the texinfo package installed. > > Applied, thanks. > > Thomas > BTW, Thomas, any idea why the autobuilders didn't catch this? Do the chroots have texinfo installed? Regards, Arnout
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: Hi, > BTW, Thomas, any idea why the autobuilders didn't catch this? Do the chroots > have texinfo installed? I cannot say for Thomas, but the autobuilders I run on gccX do not run in a chroot, and they do have texinfo installed.
Arnout, On Mon, 6 Jul 2015 23:37:49 +0200, Arnout Vandecappelle wrote: > BTW, Thomas, any idea why the autobuilders didn't catch this? Do the chroots > have texinfo installed? My chroot does not have texinfo installed: test@build:~$ dpkg -l | grep texinfo test@build:~$ which makeinfo test@build:~$ This makeinfo thing is very mysterious to me. Sometimes it complains it's missing, sometimes not. I've never been able to really understand what happens. I am wondering if some packages don't bundle the pre-generated documentation in their tarball, but sometimes have the pre-generated files with an older date than the source files, which causes the documentation to be generated once again. But that's really just a guess. Thomas
diff --git a/package/libtool/libtool.mk b/package/libtool/libtool.mk index 28786d2..8688f8b 100644 --- a/package/libtool/libtool.mk +++ b/package/libtool/libtool.mk @@ -13,6 +13,7 @@ LIBTOOL_DEPENDENCIES = host-m4 LIBTOOL_LICENSE = GPLv2+ LIBTOOL_LICENSE_FILES = COPYING +HOST_LIBTOOL_CONF_ENV = MAKEINFO=true HOST_LIBTOOL_LIBTOOL_PATCH = NO # We have a patch that affects libtool.m4, which triggers an autoreconf
host-libtool can fail to build if the host is missing makeinfo, so disable it. Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> --- Without this patch, buildroot fails to build host-libtool on my Debian 8 system, as it doesn't have the texinfo package installed. package/libtool/libtool.mk | 1 + 1 file changed, 1 insertion(+)