diff mbox

[1/1,net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

Message ID 1434484672-5877-1-git-send-email-fabf@skynet.be
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Fabian Frederick June 16, 2015, 7:57 p.m. UTC
Don't opencode sg_init_one()

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

J. Bruce Fields June 19, 2015, 7:52 p.m. UTC | #1
Thanks, applying.--b.

On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote:
> Don't opencode sg_init_one()
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> index b5408e8..fee3c15 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> @@ -881,9 +881,7 @@ krb5_rc4_setup_seq_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
>  	if (err)
>  		goto out_err;
>  
> -	sg_init_table(sg, 1);
> -	sg_set_buf(sg, &zeroconstant, 4);
> -
> +	sg_init_one(sg, &zeroconstant, 4);
>  	err = crypto_hash_digest(&desc, sg, 4, Kseq);
>  	if (err)
>  		goto out_err;
> @@ -951,9 +949,7 @@ krb5_rc4_setup_enc_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
>  	if (err)
>  		goto out_err;
>  
> -	sg_init_table(sg, 1);
> -	sg_set_buf(sg, zeroconstant, 4);
> -
> +	sg_init_one(sg, zeroconstant, 4);
>  	err = crypto_hash_digest(&desc, sg, 4, Kcrypt);
>  	if (err)
>  		goto out_err;
> -- 
> 2.4.2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
diff mbox

Patch

diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
index b5408e8..fee3c15 100644
--- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
+++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
@@ -881,9 +881,7 @@  krb5_rc4_setup_seq_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
 	if (err)
 		goto out_err;
 
-	sg_init_table(sg, 1);
-	sg_set_buf(sg, &zeroconstant, 4);
-
+	sg_init_one(sg, &zeroconstant, 4);
 	err = crypto_hash_digest(&desc, sg, 4, Kseq);
 	if (err)
 		goto out_err;
@@ -951,9 +949,7 @@  krb5_rc4_setup_enc_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
 	if (err)
 		goto out_err;
 
-	sg_init_table(sg, 1);
-	sg_set_buf(sg, zeroconstant, 4);
-
+	sg_init_one(sg, zeroconstant, 4);
 	err = crypto_hash_digest(&desc, sg, 4, Kcrypt);
 	if (err)
 		goto out_err;