diff mbox

[iproute2] enable transparent LFS

Message ID 1432623090-2264-1-git-send-email-vapier@gentoo.org
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Mike Frysinger May 26, 2015, 6:51 a.m. UTC
From: Mike Frysinger <vapier@chromium.org>

Make sure we use 64-bit filesystem functions everywhere.  This applies not
only to being able to read large files (which generally doesn't apply to
us), but also being able to simply stat them (as they might be using large
inodes).

Signed-off-by: Mike Frysinger <vapier@chromium.org>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stephen Hemminger May 27, 2015, 7:07 p.m. UTC | #1
On Tue, 26 May 2015 02:51:30 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> From: Mike Frysinger <vapier@chromium.org>
> 
> Make sure we use 64-bit filesystem functions everywhere.  This applies not
> only to being able to read large files (which generally doesn't apply to
> us), but also being able to simply stat them (as they might be using large
> inodes).
> 
> Signed-off-by: Mike Frysinger <vapier@chromium.org>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 35cacc4..9d35ef1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -32,6 +32,8 @@ ADDLIB+=mpls_ntop.o mpls_pton.o
>  CC = gcc
>  HOSTCC = gcc
>  DEFINES += -D_GNU_SOURCE
> +# Turn on transparent support for LFS
> +DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
>  CCOPTS = -O2
>  WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
>  WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2

I am okay with this, is something specific it fixes or is it just
general good practice?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mike Frysinger May 28, 2015, 12:53 a.m. UTC | #2
On 27 May 2015 12:07, Stephen Hemminger wrote:
> On Tue, 26 May 2015 02:51:30 -0400
> Mike Frysinger <vapier@gentoo.org> wrote:
> > From: Mike Frysinger <vapier@chromium.org>
> > 
> > Make sure we use 64-bit filesystem functions everywhere.  This applies not
> > only to being able to read large files (which generally doesn't apply to
> > us), but also being able to simply stat them (as they might be using large
> > inodes).
> > 
> > Signed-off-by: Mike Frysinger <vapier@chromium.org>
> > ---
> >  Makefile | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index 35cacc4..9d35ef1 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -32,6 +32,8 @@ ADDLIB+=mpls_ntop.o mpls_pton.o
> >  CC = gcc
> >  HOSTCC = gcc
> >  DEFINES += -D_GNU_SOURCE
> > +# Turn on transparent support for LFS
> > +DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> >  CCOPTS = -O2
> >  WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
> >  WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2
> 
> I am okay with this, is something specific it fixes or is it just
> general good practice?

general good practice at this point.  we've started Gentoo down the path of 
killing off non-LFS in projects.
-mike
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 35cacc4..9d35ef1 100644
--- a/Makefile
+++ b/Makefile
@@ -32,6 +32,8 @@  ADDLIB+=mpls_ntop.o mpls_pton.o
 CC = gcc
 HOSTCC = gcc
 DEFINES += -D_GNU_SOURCE
+# Turn on transparent support for LFS
+DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
 CCOPTS = -O2
 WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
 WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2