diff mbox

Succeed if make check does not report any errors

Message ID 1431499171-30140-1-git-send-email-siddhesh@redhat.com
State New
Headers show

Commit Message

Siddhesh Poyarekar May 13, 2015, 6:39 a.m. UTC 
The conditional that evaluates if there are any FAILed test cases
currently always fails, since we ensure it fails if we find any
unexpected results in tests.sum and it would obviously fail if it does
not find failed results in tests.sum.  This patch fixes this by simply
inverting the result of the egrep, i.e. succeed if egrep fails (to
find failed results) and fail if it succeeds.

Tested with 'make subdirs=localedata check' and 'make subdirs=locale
check' where all tests succeed and with 'make subdirs=elf check' where
a couple of tests fail for me.

	 * Makefile (summarize-tests): Fix return value on success.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Siddhesh Poyarekar May 18, 2015, 7:07 a.m. UTC | #1 
Ping!

On Wed, May 13, 2015 at 12:09:31PM +0530, Siddhesh Poyarekar wrote:
> The conditional that evaluates if there are any FAILed test cases
> currently always fails, since we ensure it fails if we find any
> unexpected results in tests.sum and it would obviously fail if it does
> not find failed results in tests.sum.  This patch fixes this by simply
> inverting the result of the egrep, i.e. succeed if egrep fails (to
> find failed results) and fail if it succeeds.
> 
> Tested with 'make subdirs=localedata check' and 'make subdirs=locale
> check' where all tests succeed and with 'make subdirs=elf check' where
> a couple of tests fail for me.
> 
> 	 * Makefile (summarize-tests): Fix return value on success.
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 7edf517..658ccfa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -320,7 +320,7 @@ define summarize-tests
>  @egrep -v '^(PASS|XFAIL):' $(objpfx)$1 || true
>  @echo "Summary of test results$2:"
>  @sed 's/:.*//' < $(objpfx)$1 | sort | uniq -c
> -@egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 && false
> +@! egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1
>  endef
>  
>  tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))
> -- 
> 2.1.0
>
Roland McGrath May 18, 2015, 9:09 p.m. UTC | #2 
OK
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 7edf517..658ccfa 100644
--- a/Makefile
+++ b/Makefile
@@ -320,7 +320,7 @@  define summarize-tests
 @egrep -v '^(PASS|XFAIL):' $(objpfx)$1 || true
 @echo "Summary of test results$2:"
 @sed 's/:.*//' < $(objpfx)$1 | sort | uniq -c
-@egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 && false
+@! egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1
 endef
 
 tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))