Message ID | 20100118171412.14623.94854.sendpatchset@localhost |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Mon, 18 Jan 2010 18:14:12 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] pata_ali: cleanup ali_set_piomode() > > Merge ali_fifo_control() calls. This also changes the behaviour. The old driver, reference code and old IDE driver (at least at the time I did pata_ali) all did the fifo off case, then the mode change, then the FIFO on case. I don't see why it should matter but it ought to be noted in the changelog -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ata/pata_ali.c =================================================================== --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c @@ -222,12 +222,9 @@ static void ali_set_piomode(struct ata_p } /* PIO FIFO is only permitted on ATA disk */ - if (adev->class != ATA_DEV_ATA) - ali_fifo_control(ap, adev, 0x00); - ali_program_modes(ap, adev, &t, 0); - if (adev->class == ATA_DEV_ATA) - ali_fifo_control(ap, adev, 0x05); + ali_fifo_control(ap, adev, (adev->class == ATA_DEV_ATA) ? 0x05 : 0x00); + ali_program_modes(ap, adev, &t, 0); } /**