| Message ID | 1431357666-6808-1-git-send-email-niklass@axis.com |
|---|---|
| State | Deferred, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, May 11, 2015 at 12:21 PM, Niklas Cassel <niklas.cassel@axis.com> wrote: > Don't do clock-mode-select if clk == NULL, > since when building without CONFIG_HAVE_CLK, > clk_get returns NULL and clk_get_rate returns 0. > > Doing clock-mode-select in this cause causes kszphy_probe to > return -EINVAL and thus prevents the device from being probed. > > The original code (before regression) would return 0 > when building without CONFIG_HAVE_CLK. > > Cc: stable <stable@vger.kernel.org> # 3.18+ > 1fadee0c3645 ("net/phy: micrel: Add clock support for > KSZ8021/KSZ8031") > Signed-off-by: Niklas Cassel <niklass@axis.com> Looks good now: Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 11, 2015 at 05:21:06PM +0200, Niklas Cassel wrote: > Don't do clock-mode-select if clk == NULL, > since when building without CONFIG_HAVE_CLK, > clk_get returns NULL and clk_get_rate returns 0. > > Doing clock-mode-select in this cause causes kszphy_probe to > return -EINVAL and thus prevents the device from being probed. > > The original code (before regression) would return 0 > when building without CONFIG_HAVE_CLK. > > Cc: stable <stable@vger.kernel.org> # 3.18+ > 1fadee0c3645 ("net/phy: micrel: Add clock support for > KSZ8021/KSZ8031") Looks like you forgot the "Fixes: " tag itself when updating. > Signed-off-by: Niklas Cassel <niklass@axis.com> Look good otherwise, feel free to add my Reviewed-by: Johan Hovold <johan@kernel.org> when resending (unless David wants to fix it up himself). Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 1190fd8..ebdc357 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -548,7 +548,8 @@ static int kszphy_probe(struct phy_device *phydev) } clk = devm_clk_get(&phydev->dev, "rmii-ref"); - if (!IS_ERR(clk)) { + /* NOTE: clk may be NULL if building without CONFIG_HAVE_CLK */ + if (!IS_ERR_OR_NULL(clk)) { unsigned long rate = clk_get_rate(clk); bool rmii_ref_clk_sel_25_mhz;
Don't do clock-mode-select if clk == NULL, since when building without CONFIG_HAVE_CLK, clk_get returns NULL and clk_get_rate returns 0. Doing clock-mode-select in this cause causes kszphy_probe to return -EINVAL and thus prevents the device from being probed. The original code (before regression) would return 0 when building without CONFIG_HAVE_CLK. Cc: stable <stable@vger.kernel.org> # 3.18+ 1fadee0c3645 ("net/phy: micrel: Add clock support for KSZ8021/KSZ8031") Signed-off-by: Niklas Cassel <niklass@axis.com> --- drivers/net/phy/micrel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)