| Message ID | 1431159270-2960-1-git-send-email-xi.wang@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 5/9/15 1:14 AM, Xi Wang wrote: > Extend the testcase to catch a signedness bug in the arm64 JIT: > > test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times) > > This is useful to ensure other JITs won't have a similar bug. > > Link: https://lkml.org/lkml/2015/5/8/458 > Cc: Alexei Starovoitov <ast@plumgrid.com> > Cc: Will Deacon <will.deacon@arm.com> > Signed-off-by: Xi Wang <xi.wang@gmail.com> > --- looks good. Thanks! Acked-by: Alexei Starovoitov <ast@plumgrid.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/09/2015 10:14 AM, Xi Wang wrote: > Extend the testcase to catch a signedness bug in the arm64 JIT: > > test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times) > > This is useful to ensure other JITs won't have a similar bug. > > Link: https://lkml.org/lkml/2015/5/8/458 > Cc: Alexei Starovoitov <ast@plumgrid.com> > Cc: Will Deacon <will.deacon@arm.com> > Signed-off-by: Xi Wang <xi.wang@gmail.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Xi Wang <xi.wang@gmail.com> Date: Sat, 9 May 2015 04:14:30 -0400 > Extend the testcase to catch a signedness bug in the arm64 JIT: > > test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times) > > This is useful to ensure other JITs won't have a similar bug. > > Link: https://lkml.org/lkml/2015/5/8/458 > Cc: Alexei Starovoitov <ast@plumgrid.com> > Cc: Will Deacon <will.deacon@arm.com> > Signed-off-by: Xi Wang <xi.wang@gmail.com> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib/test_bpf.c b/lib/test_bpf.c index f2c23ffaa6d7..3c41049d72d8 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -1755,7 +1755,8 @@ static struct bpf_test tests[] = { BPF_EXIT_INSN(), BPF_JMP_IMM(BPF_JEQ, R3, 0x1234, 1), BPF_EXIT_INSN(), - BPF_ALU64_IMM(BPF_MOV, R0, 1), + BPF_LD_IMM64(R0, 0x1ffffffffLL), + BPF_ALU64_IMM(BPF_RSH, R0, 32), /* R0 = 1 */ BPF_EXIT_INSN(), }, INTERNAL,
Extend the testcase to catch a signedness bug in the arm64 JIT: test_bpf: #58 load 64-bit immediate jited:1 ret -1 != 1 FAIL (1 times) This is useful to ensure other JITs won't have a similar bug. Link: https://lkml.org/lkml/2015/5/8/458 Cc: Alexei Starovoitov <ast@plumgrid.com> Cc: Will Deacon <will.deacon@arm.com> Signed-off-by: Xi Wang <xi.wang@gmail.com> --- lib/test_bpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)