Message ID | 1428707018-6405-1-git-send-email-jtoppins@cumulusnetworks.com |
---|---|
State | Awaiting Upstream, archived |
Delegated to: | David Miller |
Headers | show |
On 4/10/15 7:03 PM, Jonathan Toppins wrote: > Three of the supported PCI device entries neglected to set driver data > to "board_82575". This is not a problem until a new board type is > defined, so avoid the potential problem all together. > > Signed-off-by: Jonathan Toppins <jtoppins@cumulusnetworks.com> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index 8457d03..bb467bb 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -73,9 +73,9 @@ static const struct e1000_info *igb_info_tbl[] = { > }; > > static const struct pci_device_id igb_pci_tbl[] = { > - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_1GBPS) }, > - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_SGMII) }, > - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_2_5GBPS) }, > + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_1GBPS), board_82575 }, > + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_SGMII), board_82575 }, > + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_2_5GBPS), board_82575 }, > { PCI_VDEVICE(INTEL, E1000_DEV_ID_I211_COPPER), board_82575 }, > { PCI_VDEVICE(INTEL, E1000_DEV_ID_I210_COPPER), board_82575 }, > { PCI_VDEVICE(INTEL, E1000_DEV_ID_I210_FIBER), board_82575 }, > Simple keepalive to make sure these have not been forgotten, the patchworks entries are still in "new" state. http://patchwork.ozlabs.org/patch/460268/ http://patchwork.ozlabs.org/patch/460270/ http://patchwork.ozlabs.org/patch/460269/ Regards, -Jon -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] > On Behalf Of Jonathan Toppins > Sent: Monday, April 27, 2015 8:42 AM > To: Kirsher, Jeffrey T > Cc: Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald > C; Vick, Matthew; Ronciak, John; Williams, Mitch A; intel-wired- > lan@lists.osuosl.org; netdev@vger.kernel.org; gospo@cumulusnetworks.com; > shm@cumulusnetworks.com > Subject: Re: [PATCH v1 net-next 1/3] igb: set driver data for device > entries that were missing > > On 4/10/15 7:03 PM, Jonathan Toppins wrote: > > Three of the supported PCI device entries neglected to set driver data > > to "board_82575". This is not a problem until a new board type is > > defined, so avoid the potential problem all together. > > > > Signed-off-by: Jonathan Toppins <jtoppins@cumulusnetworks.com> > > --- > > drivers/net/ethernet/intel/igb/igb_main.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) Tested-by: Aaron Brown <aaron.f.brown@intel.com> Well, regression tested that is as I don't have any of the potential new boards. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 8457d03..bb467bb 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -73,9 +73,9 @@ static const struct e1000_info *igb_info_tbl[] = { }; static const struct pci_device_id igb_pci_tbl[] = { - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_1GBPS) }, - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_SGMII) }, - { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_2_5GBPS) }, + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_1GBPS), board_82575 }, + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_SGMII), board_82575 }, + { PCI_VDEVICE(INTEL, E1000_DEV_ID_I354_BACKPLANE_2_5GBPS), board_82575 }, { PCI_VDEVICE(INTEL, E1000_DEV_ID_I211_COPPER), board_82575 }, { PCI_VDEVICE(INTEL, E1000_DEV_ID_I210_COPPER), board_82575 }, { PCI_VDEVICE(INTEL, E1000_DEV_ID_I210_FIBER), board_82575 },
Three of the supported PCI device entries neglected to set driver data to "board_82575". This is not a problem until a new board type is defined, so avoid the potential problem all together. Signed-off-by: Jonathan Toppins <jtoppins@cumulusnetworks.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)