| Message ID | 1262690210-20763-1-git-send-email-broonie@opensource.wolfsonmicro.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Mark Brown <broonie@opensource.wolfsonmicro.com> Date: Tue, 5 Jan 2010 11:16:50 +0000 > A failure on request_irq() is always fatal but unlike other fatal > errors it's only reported to the user if net_debug is set. Make the > diagnostic unconditional and raise the priority so that errors are > more obvious to the user. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c index 5598677..9b5bbc6 100644 --- a/drivers/net/cs89x0.c +++ b/drivers/net/cs89x0.c @@ -1325,8 +1325,7 @@ net_open(struct net_device *dev) write_irq(dev, lp->chip_type, dev->irq); ret = request_irq(dev->irq, net_interrupt, 0, dev->name, dev); if (ret) { - if (net_debug) - printk(KERN_DEBUG "cs89x0: request_irq(%d) failed\n", dev->irq); + printk(KERN_ERR "cs89x0: request_irq(%d) failed\n", dev->irq); goto bad_out; } }
A failure on request_irq() is always fatal but unlike other fatal errors it's only reported to the user if net_debug is set. Make the diagnostic unconditional and raise the priority so that errors are more obvious to the user. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- drivers/net/cs89x0.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)